Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add span around status header #90597

Merged
merged 1 commit into from May 12, 2024

Conversation

Addison-Stavlo
Copy link
Contributor

Related to # Automattic/dotcom-forge#7099

Proposed Changes

  • Wraps the status header in a span tag the way the rest of the column headers are applied. As a result it inherits the intended styles.

BEFORE
Screenshot 2024-05-10 at 1 49 51 PM

AFTER
Screenshot 2024-05-10 at 1 49 37 PM

Testing Instructions

  • Run this calypso branch
  • Go to the sites dashboard
  • verify the "status" column header is capitalized like the rest.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels May 10, 2024
@Addison-Stavlo Addison-Stavlo self-assigned this May 10, 2024
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/dashboard-v2-status-header-text on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~3 bytes removed 📉 [gzipped])

name                parsed_size           gzip_size
sites-dashboard           +27 B  (+0.0%)       -3 B  (-0.0%)
site-monitoring           +27 B  (+0.0%)       -3 B  (-0.0%)
hosting                   +27 B  (+0.0%)       -3 B  (-0.0%)
github-deployments        +27 B  (+0.0%)       -3 B  (-0.0%)
dev-tools-promo           +27 B  (+0.0%)       -3 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Member

@DustyReagan DustyReagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@taipeicoder taipeicoder merged commit 633620c into trunk May 12, 2024
17 checks passed
@taipeicoder taipeicoder deleted the update/dashboard-v2-status-header-text branch May 12, 2024 23:22
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants