Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Migration: Show an error message when the site setup fails #90593

Merged
merged 7 commits into from May 21, 2024

Conversation

gabrielcaires
Copy link
Contributor

@gabrielcaires gabrielcaires commented May 10, 2024

Closes #90228

Proposed Changes

  • Show an error message guiding the user to ask for support help
  • Add tracking event when we don't have success to finish the prepare the site.

Tech changes

Add configurations to manage the retry attempts and retry delay to optimize the test execution.

Testing Instructions

It is not possible to test using calypso.live because it requires code changes to force errors.

image

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@gabrielcaires gabrielcaires marked this pull request as ready for review May 10, 2024 16:58
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@gabrielcaires gabrielcaires requested a review from a team May 13, 2024 11:48
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 13, 2024
@gabrielcaires gabrielcaires added the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label May 13, 2024
@sixhours
Copy link
Contributor

Aside from comments about color variables, this is working! 👍

@gabrielcaires gabrielcaires changed the title Site Migration: Show error message when we the site setup failed. Site Migration: Show an error message when the site setup failed May 14, 2024
@gabrielcaires gabrielcaires changed the title Site Migration: Show an error message when the site setup failed Site Migration: Show an error message when the site setup fails May 14, 2024
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/site-migration-error on your sandbox.

@gabrielcaires
Copy link
Contributor Author

@markbiek or @sixhours the e2e are finally passing. Could you please approve again?

Copy link
Contributor

@markbiek markbiek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gabrielcaires gabrielcaires merged commit bd65085 into trunk May 21, 2024
12 checks passed
@gabrielcaires gabrielcaires deleted the add/site-migration-error branch May 21, 2024 16:03
@github-actions github-actions bot removed [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove processing step: Add error message on the instructions page.
4 participants