Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multisite Scheduled Updates: Implement schedule activation toggle control in schedule list #90591

Merged
merged 15 commits into from May 14, 2024

Conversation

bogiii
Copy link
Contributor

@bogiii bogiii commented May 10, 2024

Closes #90265

Proposed Changes

  • Implement batch activation toggle
  • Update label IDs

Testing Instructions

  • Go to /plugins/scheduled-updates
  • Make sure you have a scheduled updates on multiple sites
  • Toggle batch activation and check if it works properly
  • Toggle single site activation and check if it works properly

Screen Capture on 2024-05-13 at 23-56-19

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@bogiii bogiii requested a review from a team May 10, 2024 15:52
@bogiii bogiii self-assigned this May 10, 2024
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels May 10, 2024
@matticbot
Copy link
Contributor

matticbot commented May 10, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~426 bytes added 📈 [gzipped])

name                             parsed_size           gzip_size
plugins                              +2100 B  (+0.1%)     +426 B  (+0.1%)
jetpack-cloud-plugin-management      +2100 B  (+0.1%)     +426 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@bogiii bogiii marked this pull request as ready for review May 13, 2024 21:59
Copy link
Contributor

@ouikhuan ouikhuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The functionality itself works great! But can we change the UI behavior here? If one of the child site remains active, the main toggle should also remains active. The main toggle will only be disabled when all of the child site is disabled. It is opposite at the moment.

Screen Shot 2024-05-14 at 3 19 28 PM

@bogiii bogiii requested a review from ouikhuan May 14, 2024 08:33
@bogiii
Copy link
Contributor Author

bogiii commented May 14, 2024

But can we change the UI behavior here?

Sure, it's already updated. Please re-review when you find some time.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/multisite-scheduled-updates-5 on your sandbox.

Copy link
Contributor

@ouikhuan ouikhuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm ✨

@bogiii bogiii merged commit dacb465 into trunk May 14, 2024
12 checks passed
@bogiii bogiii deleted the update/multisite-scheduled-updates-5 branch May 14, 2024 08:51
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FE: Add active toggle to multi-site level schedules
3 participants