Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add domain management restrictions for Gravatar domains #90587

Merged
merged 4 commits into from May 14, 2024

Conversation

gius80
Copy link
Contributor

@gius80 gius80 commented May 10, 2024

Proposed Changes

This PR updates domain settings and domain transfers pages to support domains used with Gravatar profiles.

For these domains, only these features are enabled:

  • contact info update;
  • external transfer out (and transfer lock);
  • cancelation;
  • renewal;
  • enable/disable autorenew;

Testing Instructions

Apply this PR locally (or use the Calypso link below) and set the gravatar flag (or force is_gravatar_domain property in the Domain_Managament_Domain class) on a domain only site.

Verify that the domain setting/transfer options are restricted (use screenshots below as a reference).

gravatar-1

gravatar-2

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@gius80 gius80 self-assigned this May 10, 2024
@gius80 gius80 requested a review from a team as a code owner May 10, 2024 15:29
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 10, 2024
@matticbot
Copy link
Contributor

matticbot commented May 10, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~466 bytes added 📈 [gzipped])

name                               parsed_size           gzip_size
domains                                 +734 B  (+0.0%)     +227 B  (+0.0%)
hosting                                 +208 B  (+0.0%)      +68 B  (+0.0%)
write-flow                              +104 B  (+0.1%)      +32 B  (+0.1%)
woocommerce-installation                +104 B  (+0.0%)      +31 B  (+0.0%)
woocommerce                             +104 B  (+0.0%)      +31 B  (+0.0%)
videopress-flow                         +104 B  (+0.0%)      +31 B  (+0.0%)
update-design-flow                      +104 B  (+0.0%)      +31 B  (+0.0%)
themes                                  +104 B  (+0.0%)      +31 B  (+0.0%)
theme                                   +104 B  (+0.0%)      +31 B  (+0.0%)
subscribers                             +104 B  (+0.0%)      +31 B  (+0.0%)
stats                                   +104 B  (+0.0%)      +31 B  (+0.0%)
sites-dashboard                         +104 B  (+0.0%)      +31 B  (+0.0%)
site-purchases                          +104 B  (+0.0%)      +31 B  (+0.0%)
site-monitoring                         +104 B  (+0.0%)      +33 B  (+0.0%)
site-blocks                             +104 B  (+0.0%)      +31 B  (+0.0%)
signup                                  +104 B  (+0.0%)      +31 B  (+0.0%)
settings-writing                        +104 B  (+0.0%)      +31 B  (+0.0%)
settings-security                       +104 B  (+0.0%)      +31 B  (+0.0%)
settings-reading                        +104 B  (+0.0%)      +31 B  (+0.0%)
settings-podcast                        +104 B  (+0.0%)      +31 B  (+0.0%)
settings-performance                    +104 B  (+0.0%)      +31 B  (+0.0%)
settings-newsletter                     +104 B  (+0.0%)      +31 B  (+0.0%)
settings-jetpack                        +104 B  (+0.0%)      +31 B  (+0.0%)
settings-discussion                     +104 B  (+0.0%)      +31 B  (+0.0%)
settings                                +104 B  (+0.0%)      +31 B  (+0.0%)
security                                +104 B  (+0.0%)      +31 B  (+0.0%)
scan                                    +104 B  (+0.0%)      +31 B  (+0.0%)
purchases                               +104 B  (+0.0%)      +31 B  (+0.0%)
promote-post-i2                         +104 B  (+0.0%)      +31 B  (+0.0%)
privacy                                 +104 B  (+0.0%)      +31 B  (+0.0%)
preview                                 +104 B  (+0.0%)      +31 B  (+0.0%)
posts-custom                            +104 B  (+0.0%)      +31 B  (+0.0%)
posts                                   +104 B  (+0.0%)      +31 B  (+0.0%)
podcasts-flow                           +104 B  (+0.0%)      +31 B  (+0.0%)
plugins                                 +104 B  (+0.0%)      +34 B  (+0.0%)
plans                                   +104 B  (+0.0%)      +31 B  (+0.0%)
people                                  +104 B  (+0.0%)      +31 B  (+0.0%)
patterns                                +104 B  (+0.0%)      +38 B  (+0.0%)
pages                                   +104 B  (+0.0%)      +31 B  (+0.0%)
notification-settings                   +104 B  (+0.0%)      +31 B  (+0.0%)
migrate                                 +104 B  (+0.0%)      +31 B  (+0.0%)
media                                   +104 B  (+0.0%)      +31 B  (+0.0%)
me                                      +104 B  (+0.0%)      +31 B  (+0.0%)
marketplace                             +104 B  (+0.0%)      +31 B  (+0.0%)
marketing                               +104 B  (+0.0%)      +31 B  (+0.0%)
link-in-bio-tld-flow                    +104 B  (+0.0%)      +31 B  (+0.0%)
jetpack-social                          +104 B  (+0.0%)      +31 B  (+0.0%)
jetpack-search                          +104 B  (+0.0%)      +31 B  (+0.0%)
jetpack-connect                         +104 B  (+0.0%)      +31 B  (+0.0%)
jetpack-cloud-settings                  +104 B  (+0.0%)      +31 B  (+0.0%)
jetpack-cloud-pricing                   +104 B  (+0.0%)      +31 B  (+0.0%)
jetpack-cloud-plugin-management         +104 B  (+0.0%)      +34 B  (+0.0%)
jetpack-cloud-partner-portal            +104 B  (+0.0%)      +31 B  (+0.0%)
jetpack-cloud-overview                  +104 B  (+0.0%)      +31 B  (+0.0%)
jetpack-cloud-features-comparison       +104 B  (+0.0%)      +31 B  (+0.0%)
jetpack-cloud-agency-sites-v2           +104 B  (+0.0%)      +35 B  (+0.0%)
jetpack-cloud                           +104 B  (+0.0%)      +31 B  (+0.0%)
incoming-redirect                       +104 B  (+0.4%)      +31 B  (+0.4%)
import                                  +104 B  (+0.0%)      +31 B  (+0.0%)
home                                    +104 B  (+0.0%)      +31 B  (+0.0%)
help                                    +104 B  (+0.0%)      +31 B  (+0.0%)
gutenberg-editor                        +104 B  (+0.0%)      +31 B  (+0.0%)
google-my-business                      +104 B  (+0.0%)      +31 B  (+0.0%)
github-deployments                      +104 B  (+0.0%)      +31 B  (+0.0%)
export                                  +104 B  (+0.0%)      +31 B  (+0.0%)
email                                   +104 B  (+0.0%)      +31 B  (+0.0%)
earn                                    +104 B  (+0.0%)      +31 B  (+0.0%)
developer                               +104 B  (+0.0%)      +31 B  (+0.0%)
dev-tools-promo                         +104 B  (+0.0%)      +31 B  (+0.0%)
customize                               +104 B  (+0.0%)      +31 B  (+0.0%)
copy-site-flow                          +104 B  (+0.0%)      +31 B  (+0.0%)
concierge                               +104 B  (+0.0%)      +31 B  (+0.0%)
comments                                +104 B  (+0.0%)      +31 B  (+0.0%)
checkout                                +104 B  (+0.0%)      +31 B  (+0.0%)
build-flow                              +104 B  (+0.1%)      +34 B  (+0.1%)
backup                                  +104 B  (+0.0%)      +31 B  (+0.0%)
add-ons                                 +104 B  (+0.0%)      +31 B  (+0.0%)
activity                                +104 B  (+0.0%)      +31 B  (+0.0%)
account-close                           +104 B  (+0.0%)      +31 B  (+0.0%)
account                                 +104 B  (+0.0%)      +31 B  (+0.0%)
a8c-for-agencies-sites                  +104 B  (+0.0%)      +35 B  (+0.0%)
a8c-for-agencies-signup                 +104 B  (+0.1%)      +31 B  (+0.1%)
a8c-for-agencies-referrals              +104 B  (+0.1%)      +31 B  (+0.1%)
a8c-for-agencies-purchases              +104 B  (+0.0%)      +31 B  (+0.0%)
a8c-for-agencies-overview               +104 B  (+0.1%)      +31 B  (+0.0%)
a8c-for-agencies-marketplace            +104 B  (+0.0%)      +31 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~31 bytes added 📈 [gzipped])

name                                                                              parsed_size           gzip_size
async-load-signup-steps-page-picker                                                    +104 B  (+0.0%)      +31 B  (+0.0%)
async-load-signup-steps-emails                                                         +104 B  (+0.2%)      +31 B  (+0.2%)
async-load-purchase-modal-wrapper                                                      +104 B  (+0.0%)      +31 B  (+0.0%)
async-load-my-sites-checkout-purchase-modal-is-eligible-for-one-click-checkou...       +104 B  (+0.0%)      +31 B  (+0.0%)
async-load-calypso-my-sites-checkout-modal                                             +104 B  (+0.0%)      +31 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

matticbot commented May 10, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/domain-management-for-gravatar-domains on your sandbox.

@gius80 gius80 force-pushed the update/domain-management-for-gravatar-domains branch from 4a1a00d to 8fd4b70 Compare May 14, 2024 08:47
Copy link
Contributor

@delputnam delputnam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and works for me.

I've tested it with a gravatar flagged domain and a WPCOM domain.

@gius80 gius80 merged commit 0ea8100 into trunk May 14, 2024
12 of 15 checks passed
@gius80 gius80 deleted the update/domain-management-for-gravatar-domains branch May 14, 2024 14:36
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants