New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add domain management restrictions for Gravatar domains #90587
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~466 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~31 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
4a1a00d
to
8fd4b70
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good and works for me.
I've tested it with a gravatar flagged domain and a WPCOM domain.
Proposed Changes
This PR updates domain settings and domain transfers pages to support domains used with Gravatar profiles.
For these domains, only these features are enabled:
Testing Instructions
Apply this PR locally (or use the Calypso link below) and set the
gravatar
flag (or forceis_gravatar_domain
property in theDomain_Managament_Domain
class) on a domain only site.Verify that the domain setting/transfer options are restricted (use screenshots below as a reference).
Pre-merge Checklist