Nav redesign - update dashboard search styles

[eoigal]

Fixes https://github.com/Automattic/dotcom-forge/issues/7070

Proposed Changes

• Moves the search icon to the right
• Update to use same icon for both search inputs
• Update icon color to match placeholder text color
• Adjusts the font size
• Adjusts the input height and width
• Updates margin above search inputs to be match on both sites and domains pages

Before

Sites

Domains

After

Sites

Domains

Testing Instructions

• Go to /sites and the '/domains/manage` pages and confirm search input matches the latest designs.

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-107493

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-107493&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-107493&env=a8c-for-agencies

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~211 bytes removed 📉 [gzipped])

name     parsed_size           gzip_size
domains       -459 B  (-0.0%)     -211 B  (-0.0%)
hosting       +110 B  (+0.0%)      +14 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[Addison-Stavlo]

Looking good.

A slight nit-pick but I imagine we will see an issue for it if we don't do it here. Can we even out the padding to the right of the icon on these pages? Here is a gif of switching between sites and domains in the sidebar:

[Addison-Stavlo]

Just noting that there is also a .is-bulk-domains-page section under the style.scss file in this directory. That could be another optional place to have these styles if we like that better than having them in the tsx file.

[Addison-Stavlo]

Note that this PR will also resolve Automattic/dotcom-forge#7089 as well

[davemart-in]

LGTM!

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/dashboard-search-styles on your sandbox.

[taipeicoder]

Works as intended 👍