New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global pages - add box shadow around content area frames #90584
Conversation
client/my-sites/domains/domain-management/list/bulk-all-domains.tsx
Outdated
Show resolved
Hide resolved
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~23 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
8f9fbab
to
f433ff2
Compare
.layout__primary > main { | ||
background: var( --color-surface ); | ||
border-radius: 8px; | ||
box-shadow: 0 0 17.4px 0 rgba( 0, 0, 0, 0.05 ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be the only change I made to this file.
Previously this had box-shadow: none
without the ending semi-colon ;
. This broke the next line and auto formatting. As soon as i updated this style and added the semi-colon, saving caused auto format to update a lot of indentations and make this look like quite a bit more changes.
3000034
to
39c8bec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks like the auto formatter changes are all in conflict with some other changes to the file now
5cd2ba9
to
1dab6a7
Compare
Related to # Automattic/dotcom-forge#7072
Proposed Changes
BEFORE
AFTER
Testing Instructions
Pre-merge Checklist