Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global pages - add box shadow around content area frames #90584

Merged
merged 1 commit into from May 13, 2024

Conversation

Addison-Stavlo
Copy link
Contributor

@Addison-Stavlo Addison-Stavlo commented May 10, 2024

Related to # Automattic/dotcom-forge#7072

Proposed Changes

  • Adds box shadow to the content frames of /me, /sites, /domains/manage, the reader.

BEFORE
Screenshot 2024-05-10 at 10 27 09 AM

AFTER
Screenshot 2024-05-10 at 10 27 15 AM

Testing Instructions

  • Run this calypso branch
  • Visit /sites, verify there is a box shadow around the primary content frame.
  • Visit /domains/manage, verify the same.
  • Visit /me, verify the same.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@Addison-Stavlo Addison-Stavlo self-assigned this May 10, 2024
@Addison-Stavlo Addison-Stavlo requested a review from a team as a code owner May 10, 2024 14:31
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 10, 2024
@matticbot
Copy link
Contributor

matticbot commented May 10, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~23 bytes added 📈 [gzipped])

name                parsed_size           gzip_size
domains                   +34 B  (+0.0%)      +23 B  (+0.0%)
sites-dashboard           -16 B  (-0.0%)       +0 B
site-monitoring           -16 B  (-0.0%)       +0 B
hosting                   -16 B  (-0.0%)       +0 B
github-deployments        -16 B  (-0.0%)       +0 B
dev-tools-promo           -16 B  (-0.0%)       +0 B

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@Addison-Stavlo Addison-Stavlo force-pushed the add/box-shadow-global-page-wrappers branch from 8f9fbab to f433ff2 Compare May 10, 2024 14:43
.layout__primary > main {
background: var( --color-surface );
border-radius: 8px;
box-shadow: 0 0 17.4px 0 rgba( 0, 0, 0, 0.05 );
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be the only change I made to this file.

Previously this had box-shadow: none without the ending semi-colon ;. This broke the next line and auto formatting. As soon as i updated this style and added the semi-colon, saving caused auto format to update a lot of indentations and make this look like quite a bit more changes.

@Addison-Stavlo Addison-Stavlo requested a review from a team as a code owner May 10, 2024 14:54
@Addison-Stavlo Addison-Stavlo force-pushed the add/box-shadow-global-page-wrappers branch from 3000034 to 39c8bec Compare May 10, 2024 14:57
Copy link
Member

@DustyReagan DustyReagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@roo2 roo2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like the auto formatter changes are all in conflict with some other changes to the file now

@Addison-Stavlo Addison-Stavlo force-pushed the add/box-shadow-global-page-wrappers branch from 5cd2ba9 to 1dab6a7 Compare May 13, 2024 12:52
@Addison-Stavlo Addison-Stavlo merged commit dd79158 into trunk May 13, 2024
11 checks passed
@Addison-Stavlo Addison-Stavlo deleted the add/box-shadow-global-page-wrappers branch May 13, 2024 13:13
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants