Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The legacy checklist endpoint is still requested after the migration #87955

Closed
valterlorran opened this issue Feb 27, 2024 · 0 comments · Fixed by #90604
Closed

The legacy checklist endpoint is still requested after the migration #87955

valterlorran opened this issue Feb 27, 2024 · 0 comments · Fixed by #90604
Assignees
Labels
[Feature] Launchpad The onboarding Launchpad that guides users through setting up their site and getting it launched.

Comments

@valterlorran
Copy link
Contributor

We noticed through the stats bump report that the requests to render the task lists were not decreasing as the runtime migration advanced. With a little investigation, I noticed that the query responsible for requesting the list of tasks is called unconditionally, causing it to load the tasks even when the Launchpad is displaying.

We need to conditionally render the query to avoid making unused requests.

{ siteId && <QuerySiteChecklist siteId={ siteId } /> }

@valterlorran valterlorran added the [Feature] Launchpad The onboarding Launchpad that guides users through setting up their site and getting it launched. label Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Launchpad The onboarding Launchpad that guides users through setting up their site and getting it launched.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant