Skip to content

Commit

Permalink
Fix Electron 5 and NodeJS 12 compatibility (#1383)
Browse files Browse the repository at this point in the history
* Fixed build for electron 5

* Updated changelog
  • Loading branch information
Rosga authored and LinusU committed Mar 15, 2019
1 parent cb958e8 commit 3d81e0a
Show file tree
Hide file tree
Showing 9 changed files with 9 additions and 8 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Expand Up @@ -10,6 +10,7 @@ project adheres to [Semantic Versioning](http://semver.org/).
### Changed
### Added
### Fixed
* Fix electron 5 and node 12 compatibility
* Fix encoding options (quality) parameter in `canvas.toDataURL()`

2.4.0
Expand Down
2 changes: 1 addition & 1 deletion src/Backends.cc
Expand Up @@ -6,7 +6,7 @@

using namespace v8;

void Backends::Initialize(Handle<Object> target) {
void Backends::Initialize(Local<Object> target) {
Nan::HandleScope scope;

Local<Object> obj = Nan::New<Object>();
Expand Down
2 changes: 1 addition & 1 deletion src/Backends.h
Expand Up @@ -6,5 +6,5 @@

class Backends : public Nan::ObjectWrap {
public:
static void Initialize(v8::Handle<v8::Object> target);
static void Initialize(v8::Local<v8::Object> target);
};
2 changes: 1 addition & 1 deletion src/backend/ImageBackend.cc
Expand Up @@ -57,7 +57,7 @@ void ImageBackend::setFormat(cairo_format_t _format) {

Nan::Persistent<FunctionTemplate> ImageBackend::constructor;

void ImageBackend::Initialize(Handle<Object> target) {
void ImageBackend::Initialize(Local<Object> target) {
Nan::HandleScope scope;

Local<FunctionTemplate> ctor = Nan::New<FunctionTemplate>(ImageBackend::New);
Expand Down
2 changes: 1 addition & 1 deletion src/backend/ImageBackend.h
Expand Up @@ -20,7 +20,7 @@ class ImageBackend : public Backend
int32_t approxBytesPerPixel();

static Nan::Persistent<v8::FunctionTemplate> constructor;
static void Initialize(v8::Handle<v8::Object> target);
static void Initialize(v8::Local<v8::Object> target);
static NAN_METHOD(New);
const static cairo_format_t DEFAULT_FORMAT = CAIRO_FORMAT_ARGB32;
};
2 changes: 1 addition & 1 deletion src/backend/PdfBackend.cc
Expand Up @@ -36,7 +36,7 @@ cairo_surface_t* PdfBackend::recreateSurface() {

Nan::Persistent<FunctionTemplate> PdfBackend::constructor;

void PdfBackend::Initialize(Handle<Object> target) {
void PdfBackend::Initialize(Local<Object> target) {
Nan::HandleScope scope;

Local<FunctionTemplate> ctor = Nan::New<FunctionTemplate>(PdfBackend::New);
Expand Down
2 changes: 1 addition & 1 deletion src/backend/PdfBackend.h
Expand Up @@ -19,6 +19,6 @@ class PdfBackend : public Backend
static Backend *construct(int width, int height);

static Nan::Persistent<v8::FunctionTemplate> constructor;
static void Initialize(v8::Handle<v8::Object> target);
static void Initialize(v8::Local<v8::Object> target);
static NAN_METHOD(New);
};
2 changes: 1 addition & 1 deletion src/backend/SvgBackend.cc
Expand Up @@ -38,7 +38,7 @@ cairo_surface_t* SvgBackend::recreateSurface() {

Nan::Persistent<FunctionTemplate> SvgBackend::constructor;

void SvgBackend::Initialize(Handle<Object> target) {
void SvgBackend::Initialize(Local<Object> target) {
Nan::HandleScope scope;

Local<FunctionTemplate> ctor = Nan::New<FunctionTemplate>(SvgBackend::New);
Expand Down
2 changes: 1 addition & 1 deletion src/backend/SvgBackend.h
Expand Up @@ -19,6 +19,6 @@ class SvgBackend : public Backend
static Backend *construct(int width, int height);

static Nan::Persistent<v8::FunctionTemplate> constructor;
static void Initialize(v8::Handle<v8::Object> target);
static void Initialize(v8::Local<v8::Object> target);
static NAN_METHOD(New);
};

0 comments on commit 3d81e0a

Please sign in to comment.