Merge pull request #4837 from billouboq/micro-optimisations

Micro optimisations
Automattic · Dec 29, 2016 · ecc6cfe · ecc6cfe
2 parents 90878d3 + d4bfb33
commit ecc6cfe
Showing 1 changed file with 8 additions and 9 deletions.
diff --git a/lib/query.js b/lib/query.js
@@ -984,7 +984,6 @@ Query.prototype._updateForExec = function() {
     }
   }
 
-  this._compiledUpdate = ret;
   return ret;
 };
 
@@ -1095,7 +1094,7 @@ Query.prototype._find = function(callback) {
     if (!options.populate) {
       return options.lean === true
           ? callback(null, docs)
-          : completeMany(_this.model, docs, fields, _this, null, callback);
+          : completeMany(_this.model, docs, fields, null, callback);
     }
 
     var pop = helpers.preparePopulationOptionsMQ(_this, options);
@@ -1104,7 +1103,7 @@ Query.prototype._find = function(callback) {
       if (err) return callback(err);
       return options.lean === true
           ? callback(null, docs)
-          : completeMany(_this.model, docs, fields, _this, pop, callback);
+          : completeMany(_this.model, docs, fields, pop, callback);
     });
   };
 
@@ -1219,7 +1218,7 @@ Query.prototype.merge = function(source) {
  * @param {Function} callback
  */
 
-function completeMany(model, docs, fields, self, pop, callback) {
+function completeMany(model, docs, fields, pop, callback) {
   var arr = [];
   var count = docs.length;
   var len = count;
@@ -1268,7 +1267,7 @@ Query.prototype._findOne = function(callback) {
     if (!options.populate) {
       return options.lean === true
           ? callback(null, doc)
-          : completeOne(_this.model, doc, null, projection, _this, null, callback);
+          : completeOne(_this.model, doc, null, projection, null, callback);
     }
 
     var pop = helpers.preparePopulationOptionsMQ(_this, options);
@@ -1279,7 +1278,7 @@ Query.prototype._findOne = function(callback) {
       }
       return options.lean === true
           ? callback(null, doc)
-          : completeOne(_this.model, doc, null, projection, _this, pop, callback);
+          : completeOne(_this.model, doc, null, projection, pop, callback);
     });
   });
 };
@@ -1600,7 +1599,7 @@ Query.prototype.remove = function(cond, callback) {
  * @param {Function} callback
  */
 
-function completeOne(model, doc, res, fields, self, pop, callback) {
+function completeOne(model, doc, res, fields, pop, callback) {
   var opts = pop ?
   {populated: pop}
       : undefined;
@@ -1936,7 +1935,7 @@ Query.prototype._findAndModify = function(type, callback) {
     if (!options.populate) {
       return options.lean === true
           ? (opts.passRawResult ? callback(null, doc, res) : callback(null, doc))
-          : completeOne(_this.model, doc, res, fields, _this, null, callback);
+          : completeOne(_this.model, doc, res, fields, null, callback);
     }
 
     var pop = helpers.preparePopulationOptionsMQ(_this, options);
@@ -1948,7 +1947,7 @@ Query.prototype._findAndModify = function(type, callback) {
 
       return options.lean === true
           ? (opts.passRawResult ? callback(null, doc, res) : callback(null, doc))
-          : completeOne(_this.model, doc, res, fields, _this, pop, callback);
+          : completeOne(_this.model, doc, res, fields, pop, callback);
     });
   };