Merge branch 'master' into 4.10

Conflicts:
	lib/schema.js
	package.json
	test/document.test.js

.github/ISSUE_TEMPLATE.md

@@ -5,7 +5,7 @@
 **What is the current behavior?**
 
 **If the current behavior is a bug, please provide the steps to reproduce.**
-<!-- If you can, provide a stadalone script / gist to reproduce your issue -->
+<!-- If you can, provide a standalone script / gist to reproduce your issue -->
 
 **What is the expected behavior?**
 

History.md

@@ -1,3 +1,9 @@
+4.9.10 / 2017-05-17
+===================
+ * fix(connection): ensure callback arg to openSet() is handled properly #5249
+ * docs: remove dead plugins repo and add content links #5247
+ * fix(model): skip index build if connecting after model init and autoIndex false #5176
+
 4.9.9 / 2017-05-13
 ==================
  * docs: correct value for Query#regex() #5230

README.md

@@ -22,9 +22,7 @@ Mongoose is a [MongoDB](https://www.mongodb.org/) object modeling tool designed
 
 ## Plugins
 
-Check out the [plugins search site](http://plugins.mongoosejs.io/) to see hundreds of related modules from the community.
-
-Build your own Mongoose plugin through [generator-mongoose-plugin](https://github.com/huei90/generator-mongoose-plugin).
+Check out the [plugins search site](http://plugins.mongoosejs.io/) to see hundreds of related modules from the community. Next, learn how to write your own plugin from the [docs](http://mongoosejs.com/docs/plugins.html) or [this blog post](http://thecodebarbarian.com/2015/03/06/guide-to-mongoose-plugins).
 
 ## Contributors
 

docs/populate.jade

@@ -330,7 +330,10 @@ block content
     BandSchema.virtual('members', {
       ref: 'Person', // The model to use
       localField: 'name', // Find people where `localField`
-      foreignField: 'band' // is equal to `foreignField`
+      foreignField: 'band', // is equal to `foreignField`
+      // If `justOne` is false, 'members' will be a single doc as opposed to
+      // an array. `justOne` is false by default.
+      justOne: false
     });
 
     var Person = mongoose.model('Person', personSchema);

lib/connection.js

@@ -487,6 +487,8 @@ Connection.prototype._handleOpenSetArgs = function(uris, database, options, call
   if (options && options.config) {
     this.config.autoIndex = options.config.autoIndex !== false;
   }
+
+  return callback;
 };
 
 /*!

lib/document.js

@@ -624,18 +624,6 @@ Document.prototype.set = function(path, val, type, options) {
   var schema;
   var parts = path.split('.');
 
-  // gh-4578, if setting a deeply nested path that doesn't exist yet, create it
-  var cur = this._doc;
-  var curPath = '';
-  for (i = 0; i < parts.length - 1; ++i) {
-    cur = cur[parts[i]];
-    curPath += (curPath.length > 0 ? '.' : '') + parts[i];
-    if (!cur) {
-      this.set(curPath, {});
-      cur = this.getValue(curPath);
-    }
-  }
-
   if (pathType === 'adhocOrUndefined' && strict) {
     // check for roots that are Mixed types
     var mixed;
@@ -670,6 +658,18 @@ Document.prototype.set = function(path, val, type, options) {
     schema = this.$__path(path);
   }
 
+  // gh-4578, if setting a deeply nested path that doesn't exist yet, create it
+  var cur = this._doc;
+  var curPath = '';
+  for (i = 0; i < parts.length - 1; ++i) {
+    cur = cur[parts[i]];
+    curPath += (curPath.length > 0 ? '.' : '') + parts[i];
+    if (!cur) {
+      this.set(curPath, {});
+      cur = this.getValue(curPath);
+    }
+  }
+
   var pathToMark;
 
   // When using the $set operator the path to the field must already exist.

lib/model.js

@@ -861,7 +861,7 @@ for (var i in EventEmitter.prototype) {
 
 Model.init = function init() {
   if ((this.schema.options.autoIndex) ||
-      (this.schema.options.autoIndex === null && this.db.config.autoIndex)) {
+      (this.schema.options.autoIndex == null && this.db.config.autoIndex)) {
     this.ensureIndexes({ __noPromise: true, _automatic: true });
   }
 
@@ -955,6 +955,11 @@ function _ensureIndexes(model, options, callback) {
   };
 
   var create = function() {
+    if (model.schema.options.autoIndex === false ||
+        (model.schema.options.autoIndex == null && model.db.config.autoIndex === false)) {
+      return done();
+    }
+
     var index = indexes.shift();
     if (!index) return done();
 

lib/schema.js

@@ -309,6 +309,7 @@ Schema.prototype.clone = function() {
   s.methods = utils.clone(this.methods);
   s.statics = utils.clone(this.statics);
   s.plugins = Array.prototype.slice.call(this.plugins);
+  s._indexes = utils.clone(this._indexes);
   s.s.hooks = this.s.hooks.clone();
   return s;
 };

test/document.test.js

@@ -4064,6 +4064,24 @@ describe('document', function() {
       done();
     });
 
+    it('deeply nested virtual paths (gh-5250)', function(done) {
+      var TestSchema = new Schema({});
+      TestSchema.
+        virtual('a.b.c').
+        get(function() {
+          return this.v;
+        }).
+        set(function(value) {
+          this.v = value;
+        });
+
+      var TestModel = db.model('gh5250', TestSchema);
+      var t = new TestModel({'a.b.c': 5});
+      assert.equal(t.a.b.c, 5);
+
+      done();
+    });
+
     it('JSON.stringify nested errors (gh-5208)', function(done) {
       var AdditionalContactSchema = new Schema({
         contactName: {