fix(documentarray): report validation errors that occur in an array s…

…ubdoc created using `create()` and then `set()`

Fix #7504

lib/schema/documentarray.js

@@ -369,7 +369,11 @@ DocumentArray.prototype.cast = function(value, doc, init, prev, options) {
         value[i].schema !== Constructor.schema) {
       value[i] = value[i].toObject({ transform: false, virtuals: false });
     }
-    if (!(value[i] instanceof Subdocument) && value[i]) {
+
+    if (value[i] instanceof Subdocument) {
+      // Might not have the correct index yet, so ensure it does.
+      value[i].$setIndex(i);
+    } else if (value[i] != null) {
       if (init) {
         if (doc) {
           selected || (selected = scopePaths(this, doc.$__.selected, init));

lib/types/documentarray.js

@@ -310,7 +310,7 @@ MongooseDocumentArray.mixin = {
       }
     }
 
-    return new Constructor(obj);
+    return new Constructor(obj, this);
   },
 
   /**

lib/types/embedded.js

@@ -277,19 +277,17 @@ if (util.inspect.custom) {
 EmbeddedDocument.prototype.invalidate = function(path, err, val) {
   Document.prototype.invalidate.call(this, path, err, val);
 
-  if (!this[documentArrayParent]) {
+  if (!this[documentArrayParent] || this.__index == null) {
     if (err[validatorErrorSymbol] || err.name === 'ValidationError') {
       return true;
     }
     throw err;
   }
 
   const index = this.__index;
-  if (typeof index !== 'undefined') {
-    const parentPath = this.__parentArray._path;
-    const fullPath = [parentPath, index, path].join('.');
-    this[documentArrayParent].invalidate(fullPath, err, val);
-  }
+  const parentPath = this.__parentArray._path;
+  const fullPath = [parentPath, index, path].join('.');
+  this[documentArrayParent].invalidate(fullPath, err, val);
 
   return true;
 };