Merge pull request #5192 from jhob/gh-5189

Update `parentArray` references when directly assigning document arrays

lib/document.js

@@ -878,6 +878,13 @@ Document.prototype.$__set = function(pathToMark, path, constructing, parts, sche
     if (val && val.isMongooseArray) {
       val._registerAtomic('$set', val);
 
+      // Update embedded document parent references (gh-5189)
+      if (val.isMongooseDocumentArray) {
+        val.forEach(function(item) {
+          item && item.__parentArray && (item.__parentArray = val);
+        });
+      }
+
       // Small hack for gh-1638: if we're overwriting the entire array, ignore
       // paths that were modified before the array overwrite
       this.$__.activePaths.forEach(function(modifiedPath) {

test/document.modified.test.js

@@ -465,6 +465,28 @@ describe('document modified', function() {
 
         done();
       });
+
+      it('updates embedded doc parents upon direct assignment (gh-5189)', function(done) {
+        var db = start();
+        var familySchema = new Schema({
+          children: [{name: {type: String, required: true}}]
+        });
+        var Family = db.model('Family', familySchema);
+        Family.create({
+          children: [
+            {name: 'John'},
+            {name: 'Mary'}
+          ]
+        }, function(err, family) {
+          family.set({children: family.children.slice(1)});
+          family.children.forEach(function(child) {
+            child.set({name: 'Maryanne'});
+          });
+
+          assert.equal(family.validateSync(), undefined);
+          done();
+        });
+      });
     });
 
     it('should support setting mixed paths by string (gh-1418)', function(done) {