fix(document): don't create a new array subdoc when creating schema a…

…rray Fix #5162
Automattic · Apr 20, 2017 · 190374a · 190374a
1 parent d467f05
commit 190374a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/lib/schema/array.js b/lib/schema/array.js
@@ -63,7 +63,7 @@ function SchemaArray(key, cast, options, schemaOptions) {
         : cast;
 
     this.casterConstructor = caster;
-    if (typeof caster === 'function') {
+    if (typeof caster === 'function' && !caster.$isArraySubdocument) {
       this.caster = new caster(null, castOptions);
     } else {
       this.caster = caster;

diff --git a/lib/types/array.js b/lib/types/array.js
@@ -119,10 +119,10 @@ MongooseArray.mixin = {
       if (!isDisc) {
         value = new Model(value);
       }
-      return this._schema.caster.cast(value, this._parent, true);
+      return this._schema.caster.applySetters(value, this._parent, true);
     }
 
-    return this._schema.caster.cast(value, this._parent, false);
+    return this._schema.caster.applySetters(value, this._parent, false);
   },
 
   /**
@@ -698,10 +698,6 @@ MongooseArray.mixin = {
 
   set: function set(i, val) {
     var value = this._cast(val, i);
-    value = this._schema.caster instanceof EmbeddedDocument ?
-        value :
-        this._schema.caster.applySetters(val, this._parent)
-    ;
     this[i] = value;
     this._markModified(i);
     return this;