Fix: overindent in VariableDeclarator parens or brackets (fixes #5492)

eslint · Mar 7, 2016 · ad100fd · ad100fd
1 parent bb8f470
commit ad100fd
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 4 deletions.
diff --git a/lib/rules/indent.js b/lib/rules/indent.js
@@ -444,7 +444,7 @@ module.exports = function(context) {
             nodeIndent = getNodeIndent(effectiveParent);
             if (parentVarNode && parentVarNode.loc.start.line !== node.loc.start.line) {
                 if (parent.type !== "VariableDeclarator" || parentVarNode === parentVarNode.parent.declarations[0]) {
-                    if (parentVarNode.loc.start.line === effectiveParent.loc.start.line) {
+                    if (parent.type === "VariableDeclarator" && parentVarNode.loc.start.line === effectiveParent.loc.start.line) {
                         nodeIndent = nodeIndent + (indentSize * options.VariableDeclarator[parentVarNode.parent.kind]);
                     } else if (
                         parent.type === "ObjectExpression" ||

diff --git a/tests/lib/rules/indent.js b/tests/lib/rules/indent.js
@@ -760,12 +760,30 @@ ruleTester.run("indent", rule, {
         {
             code:
                 "var items = [\n" +
-                "    {\n" +
-                "      foo: 'bar'\n" +
-                "    }\n" +
+                "  {\n" +
+                "    foo: 'bar'\n" +
+                "  }\n" +
                 "];\n",
             options: [2, {"VariableDeclarator": 2}]
         },
+        {
+            code:
+                "const a = 1,\n" +
+                "      b = 2;\n" +
+                "const items1 = [\n" +
+                "  {\n" +
+                "    foo: 'bar'\n" +
+                "  }\n" +
+                "];\n" +
+                "const items2 = Items(\n" +
+                "  {\n" +
+                "    foo: 'bar'\n" +
+                "  }\n" +
+                ");\n",
+            options: [2, {"VariableDeclarator": 3}],
+            parserOptions: { ecmaVersion: 6 }
+
+        },
         {
             code:
                 "const geometry = 2,\n" +