Fix: key-spacing checks ObjectExpression is multiline (fixes #5479)

eslint · Mar 5, 2016 · 38eb7f1 · 38eb7f1
1 parent ef341be
commit 38eb7f1
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/lib/rules/key-spacing.js b/lib/rules/key-spacing.js
@@ -370,7 +370,7 @@ module.exports = function(context) {
 
         return {
             "Property": function(node) {
-                verifySpacing(node, isSingleLine(node) ? singleLineOptions : multiLineOptions);
+                verifySpacing(node, isSingleLine(node.parent) ? singleLineOptions : multiLineOptions);
             }
         };
 

diff --git a/tests/lib/rules/key-spacing.js b/tests/lib/rules/key-spacing.js
@@ -479,6 +479,25 @@ ruleTester.run("key-spacing", rule, {
                 "beforeColon": false
             }
         }]
+    }, {
+        code: [
+            "var obj = {",
+            "    foobar: 42,",
+            "    bat:    2",
+            "};"
+        ].join("\n"),
+        options: [{
+            singleLine: {
+                beforeColon: false,
+                afterColon: true,
+                mode: "strict"
+            },
+            multiLine: {
+                beforeColon: false,
+                afterColon: true,
+                mode: "minimum"
+            }
+        }]
     }],
 
     invalid: [{