Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider wider CI recognition #707

Closed
yomed opened this issue Nov 27, 2019 · 3 comments
Closed

Consider wider CI recognition #707

yomed opened this issue Nov 27, 2019 · 3 comments

Comments

@yomed
Copy link

yomed commented Nov 27, 2019

Hi, I noticed that the postinstall script attempts to recognize CI before showing the banner. It would be great if this supported a wider range of CI services, since not all of them use the CI environment variable.

var CI = is(env.CI);

There are packages that help support more CI services:
https://github.com/watson/ci-info#api

I can submit a PR if we are ok making this change. Thanks!

@zloirock
Copy link
Owner

zloirock commented Nov 27, 2019

The problem that core-js should follow a zero-dependency policy. However, I'll take a look at this, thanks. You can create a PR for the usage of those practices.

@zloirock
Copy link
Owner

zloirock commented Dec 2, 2019

Feel free to improve it.

@yomed
Copy link
Author

yomed commented Dec 2, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants