Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Math.signbit semantics #687

Merged
merged 1 commit into from Nov 3, 2019
Merged

Fix Math.signbit semantics #687

merged 1 commit into from Nov 3, 2019

Conversation

chicoxyzzy
Copy link
Contributor

@chicoxyzzy chicoxyzzy commented Nov 3, 2019 •
edited

According to the spec draft, Math.signbit returns true only for negative values and Math.signbit(NaN) should return false

@chicoxyzzy
Fix Math.signbit semantics
311373f 
According [spec draft](https://tc39.es/proposal-Math.signbit/Math.signbit.html#spec), Math.signbit returns `true` only for negative values and `Math.signbit(NaN)` should return `true`
@zloirock
Copy link
Owner

zloirock commented Nov 3, 2019

Hmm...

@zloirock
Copy link
Owner

zloirock commented Nov 3, 2019 •
edited

IIRC, this polyfill in the core-js from the time when the spec was not ready. So seems I missed up something.

@zloirock
Copy link
Owner

zloirock commented Nov 3, 2019

Thanks.

@zloirock zloirock merged commit 948e642 into zloirock:master Nov 3, 2019
@chicoxyzzy chicoxyzzy deleted the patch-1 branch November 3, 2019 21:33
This was referenced Nov 15, 2019
Merged
Closed
This was referenced Dec 4, 2019
Closed
Open
Closed
Merged
Merged
@snyk-bot snyk-bot mentioned this pull request Dec 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chicoxyzzy @zloirock