Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing deps to package.json #1137

Merged
merged 1 commit into from Feb 25, 2018
Merged

Added missing deps to package.json #1137

merged 1 commit into from Feb 25, 2018

Conversation

spal1
Copy link
Contributor

@spal1 spal1 commented Feb 24, 2018

When I tried to npm install, it was complaining about some dependencies not existing. I added these dependencies to package.json

image

@leo quick fix?

@leo
Copy link
Contributor

leo commented Feb 25, 2018

Thanks for the effort you've put into this 😊 But npm install doesn't generate such error messages. Maybe you got it from running npm run dev inside the repositorie's directory?

I tried running it on all branches and it always works fine - just like the installating of Now CLI itself (npm install now -g).

@leo leo closed this Feb 25, 2018
@spal1
Copy link
Contributor Author

spal1 commented Feb 25, 2018

@leo Sorry, I actually ran npm run build and received the errors in the photo above.

@matheuss matheuss reopened this Feb 25, 2018
@matheuss matheuss merged commit eab8692 into vercel:canary Feb 25, 2018
@matheuss
Copy link
Member

@spal1 thank you 😱 I wonder how they went missing from package.json 😥

@leo
Copy link
Contributor

leo commented Feb 25, 2018

Seems like they were previously defined by sub dependencies, so it just worked without any errors for me. But you're right, they should be defined in package.json... 👍

leo pushed a commit that referenced this pull request Feb 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants