update hoist-non-react-statics #5116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kachkaev
reviewed
Sep 6, 2018
package.json
Outdated
| @@ -155,4 +155,4 @@ | |||
| "test/" | |||
| ] | |||
| } | |||
| } | |||
| } | |||
you folks should really use semver ranges, but since greenkeeper is no longer running for this branch things have fallen behind in particular, there seems to be an incompatibility with multiple v2.x versions of this package in the same bundle as displayed here: styled-components/styled-components#1972 When I force resolution to a particular h-n-r-s version, the issue goes away. This is true for both next 6 and next 7 canary. But really you folks should use semver carets instead of pinning.
quantizor
force-pushed
the
hnrs-semver
branch
from
625bf7a
to
4d23689
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
you folks should really use semver ranges, but since greenkeeper
is no longer running for this branch things have fallen behind
in particular, there seems to be an incompatibility with multiple
v2.x versions of this package in the same bundle as displayed here:
styled-components/styled-components#1972
When I force resolution to a particular h-n-r-s version, the issue
goes away. This is true for both next 6 and next 7 canary.
But really you folks should use semver carets instead of pinning