Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added with-unstated example #4628

Merged
merged 3 commits into from Jun 19, 2018
Merged

Conversation

bennygenel
Copy link
Contributor

Small example app using unstated library. Example uses components and logic from with-redux example.

Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 💯

@timneutkens timneutkens merged commit 67cb87a into vercel:canary Jun 19, 2018
@bennygenel bennygenel deleted the with-unstated branch June 19, 2018 19:54
@bennygenel bennygenel restored the with-unstated branch July 2, 2018 08:04
@omaksi
Copy link
Contributor

omaksi commented Jul 16, 2018

I was excited when I saw this example, but then I found out it doesn't use server side rendering at all, so it is not very helpful, and also not like the redux example, so the description is misleading...

@mikkmartin
Copy link

Also this example resets the state when the route changes, which defeats the purpose.

@lkostrowski
Copy link
Contributor

I think this should be deleted or at least annotated that it's without SSR. I think Next's examples are very valuable, because they show quirks with pages and ssr approach.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants