Example: Improve ReasonML example #3021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lib folder contains code generated by BuckleScript, it shouldn't be versioned.
Next.js use case-sensitive-paths-webpack-plugin and BuckleScript tries to maintain the filename case.
This is the official recommended way in Next.js
Adds `"bsc-flags": ["-bs-super-errors"]` to the bsconfig.json file. https://reasonml.github.io/community/blog/#way-way-waaaay-nicer-error-messages
|
@mike-engel since you first pushed the initial example for ReasonML/ReactReason, I'd love to have your input on this. I'm just starting with ReasonML. |
timneutkens
approved these changes
Sep 30, 2017
|
Thanks guys! |
|
With pleasure! |
|
please upgrade to reasonml 3 |
|
This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improve the example for ReasonML
with-reasonml.While trying to run this example, I run into different issues, this PR is meant to fix them. While at it, this also upgrade some dependencies, including upgrading to next.js v3. And make some other improvements, enable nicer error msgs and update the example to use the new recommended
ReasonReact.reducerComponentinstead ofReasonReact.statefulComponent- more read about this here.Note: I believe that the
package-lock.jsonshould be versioned in the examples, especially for theses kind of example which use "bleeding edge" stuff prone to break at any new deps update. However, #2623 ignore them, not sure why, so I didn't add the file.