Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat navigation to empty hash as hash navigate #2971

Merged
merged 1 commit into from Sep 27, 2017

Conversation

kpdecker
Copy link
Contributor

@kpdecker kpdecker commented Sep 21, 2017

# -> #foo and #foo -> # now operate in the same way.

# -> #foo and #foo -> # now operate in the same way.
Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@timneutkens timneutkens merged commit c6bd6ef into vercel:master Sep 27, 2017
arunoda added a commit that referenced this pull request Sep 28, 2017
arunoda added a commit that referenced this pull request Sep 28, 2017
arunoda added a commit that referenced this pull request Sep 28, 2017
* Revert "Keep some buffered pages, that won't be disposed. Fix #1939 (#2592)"

This reverts commit 3643612.

* Revert "Add beta installation instruction"

This reverts commit 418cc21.

* Revert "4.0.0-beta.1"

This reverts commit c2d98e2.

* Revert "Treat navigation to empty hash as hash navigate (#2971)"

This reverts commit c6bd6ef.

* Revert "React 16 (fiber) (#2996)"

This reverts commit d19cc97.
@kpdecker kpdecker deleted the hash-change branch October 17, 2017 14:42
@lock
Copy link

lock bot commented May 10, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators May 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants