Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Examples] Update with-mobx-state-tree examples #11736

Merged

Conversation

lfades
Copy link
Member

@lfades lfades commented Apr 7, 2020

This PR updates with-mobx-state-tree and its TypeScript version.

two new pages have been added to show how would the store be used for server side data fetching methods that may needed, without losing static capabilities for pages that don't.

@lfades lfades requested a review from Timer as a code owner April 7, 2020 19:44
@lfades lfades requested a review from timneutkens April 7, 2020 19:45
@lfades lfades changed the title [Examples] Updated with-mobx-state-tree examples [Examples] Update with-mobx-state-tree examples Apr 7, 2020
@lfades lfades added the examples Issue/PR related to examples label Apr 7, 2020
@ijjk
Copy link
Member

ijjk commented Apr 7, 2020

Stats from current PR

Default Server Mode
General
zeit/next.js canary lfades/next.js examples/update-with-mobx-state-tree Change
buildDuration 10.9s 10.9s -11ms
nodeModulesSize 52.5 MB 52.5 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary lfades/next.js examples/update-with-mobx-state-tree Change
main-HASH.js gzip 6.25 kB 6.25 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..e3d8.js gzip 10.2 kB 10.2 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 56.3 kB 56.3 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary lfades/next.js examples/update-with-mobx-state-tree Change
main-HASH.module.js gzip 4.78 kB 4.78 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.78 kB 6.78 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 51.5 kB 51.5 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary lfades/next.js examples/update-with-mobx-state-tree Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary lfades/next.js examples/update-with-mobx-state-tree Change
_app.js gzip 1.24 kB 1.24 kB
_error.js gzip 3.15 kB 3.15 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 2.03 kB 2.03 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.86 kB 7.86 kB
Client Pages Modern
zeit/next.js canary lfades/next.js examples/update-with-mobx-state-tree Change
_app.module.js gzip 594 B 594 B
_error.module.js gzip 2.08 kB 2.08 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.28 kB 5.28 kB
Client Build Manifests
zeit/next.js canary lfades/next.js examples/update-with-mobx-state-tree Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Rendered Page Sizes
zeit/next.js canary lfades/next.js examples/update-with-mobx-state-tree Change
index.html gzip 918 B 918 B
link.html gzip 926 B 926 B
withRouter.html gzip 913 B 913 B
Overall change 2.76 kB 2.76 kB

Serverless Mode (Decrease detected ✓)
General
zeit/next.js canary lfades/next.js examples/update-with-mobx-state-tree Change
buildDuration 11.5s 11.5s -49ms
nodeModulesSize 52.5 MB 52.5 MB
Client Bundles (main, webpack, commons)
zeit/next.js canary lfades/next.js examples/update-with-mobx-state-tree Change
main-HASH.js gzip 6.25 kB 6.25 kB
webpack-HASH.js gzip 746 B 746 B
de003c3a9d30..e3d8.js gzip 10.2 kB 10.2 kB
framework.HASH.js gzip 39.1 kB 39.1 kB
Overall change 56.3 kB 56.3 kB
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary lfades/next.js examples/update-with-mobx-state-tree Change
main-HASH.module.js gzip 4.78 kB 4.78 kB
webpack-HASH..dule.js gzip 746 B 746 B
de003c3a9d30..dule.js gzip 6.78 kB 6.78 kB
framework.HA..dule.js gzip 39.1 kB 39.1 kB
Overall change 51.5 kB 51.5 kB
Legacy Client Bundles (polyfills)
zeit/next.js canary lfades/next.js examples/update-with-mobx-state-tree Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB
Overall change 26.3 kB 26.3 kB
Client Pages
zeit/next.js canary lfades/next.js examples/update-with-mobx-state-tree Change
_app.js gzip 1.24 kB 1.24 kB
_error.js gzip 3.15 kB 3.15 kB
hooks.js gzip 664 B 664 B
index.js gzip 222 B 222 B
link.js gzip 2.03 kB 2.03 kB
routerDirect.js gzip 279 B 279 B
withRouter.js gzip 278 B 278 B
Overall change 7.86 kB 7.86 kB
Client Pages Modern
zeit/next.js canary lfades/next.js examples/update-with-mobx-state-tree Change
_app.module.js gzip 594 B 594 B
_error.module.js gzip 2.08 kB 2.08 kB
hooks.module.js gzip 370 B 370 B
index.module.js gzip 212 B 212 B
link.module.js gzip 1.48 kB 1.48 kB
routerDirect..dule.js gzip 271 B 271 B
withRouter.m..dule.js gzip 270 B 270 B
Overall change 5.28 kB 5.28 kB
Client Build Manifests
zeit/next.js canary lfades/next.js examples/update-with-mobx-state-tree Change
_buildManifest.js gzip 61 B 61 B
_buildManife..dule.js gzip 61 B 61 B
Overall change 122 B 122 B
Serverless bundles Overall decrease ✓
zeit/next.js canary lfades/next.js examples/update-with-mobx-state-tree Change
_error.js gzip 233 kB 233 kB ⚠️ +77 B
404.html gzip 1.32 kB 1.32 kB
hooks.html gzip 956 B 956 B
index.js gzip 233 kB 233 kB -244 B
link.js gzip 243 kB 243 kB ⚠️ +64 B
routerDirect.js gzip 241 kB 241 kB -57 B
withRouter.js gzip 241 kB 241 kB -313 B
Overall change 1.19 MB 1.19 MB -473 B

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants