feat(example): add CRUD example with next-connect and passport #11359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless Mode (Increase detected
|
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| buildDuration | 13.2s | 12.9s | -235ms |
| nodeModulesSize | 53 MB | 53 MB | ✓ |
Client Bundles (main, webpack, commons)
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| main-HASH.js gzip | 6.24 kB | 6.24 kB | ✓ |
| webpack-HASH.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..c6c1.js gzip | 10.1 kB | 10.1 kB | ✓ |
| framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 56.2 kB | 56.2 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| main-HASH.module.js gzip | 4.78 kB | 4.78 kB | ✓ |
| webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..dule.js gzip | 6.71 kB | 6.71 kB | ✓ |
| framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 51.4 kB | 51.4 kB | ✓ |
Legacy Client Bundles (polyfills)
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 26.3 kB | 26.3 kB | ✓ |
| Overall change | 26.3 kB | 26.3 kB | ✓ |
Client Pages
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| _app.js gzip | 1.24 kB | 1.24 kB | ✓ |
| _error.js gzip | 3.15 kB | 3.15 kB | ✓ |
| hooks.js gzip | 664 B | 664 B | ✓ |
| index.js gzip | 222 B | 222 B | ✓ |
| link.js gzip | 2.03 kB | 2.03 kB | ✓ |
| routerDirect.js gzip | 279 B | 279 B | ✓ |
| withRouter.js gzip | 278 B | 278 B | ✓ |
| Overall change | 7.86 kB | 7.86 kB | ✓ |
Client Pages Modern
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| _app.module.js gzip | 594 B | 594 B | ✓ |
| _error.module.js gzip | 2.08 kB | 2.08 kB | ✓ |
| hooks.module.js gzip | 370 B | 370 B | ✓ |
| index.module.js gzip | 212 B | 212 B | ✓ |
| link.module.js gzip | 1.48 kB | 1.48 kB | ✓ |
| routerDirect..dule.js gzip | 271 B | 271 B | ✓ |
| withRouter.m..dule.js gzip | 270 B | 270 B | ✓ |
| Overall change | 5.28 kB | 5.28 kB | ✓ |
Client Build Manifests
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 61 B | 61 B | ✓ |
| _buildManife..dule.js gzip | 61 B | 61 B | ✓ |
| Overall change | 122 B | 122 B | ✓ |
Serverless bundles Overall increase ⚠️
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| _error.js gzip | 293 kB | 293 kB | |
| 404.html gzip | 1.32 kB | 1.32 kB | ✓ |
| hooks.html gzip | 957 B | 957 B | ✓ |
| index.js gzip | 294 kB | 294 kB | -609 B |
| link.js gzip | 301 kB | 301 kB | |
| routerDirect.js gzip | 300 kB | 300 kB | |
| withRouter.js gzip | 300 kB | 300 kB | -216 B |
| Overall change | 1.49 MB | 1.49 MB |
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless Mode (Decrease detected ✓)General
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Serverless bundles Overall decrease ✓
|
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless Mode (Increase detected
|
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| buildDuration | 11.4s | 11.9s | |
| nodeModulesSize | 53 MB | 53 MB | ✓ |
Client Bundles (main, webpack, commons)
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| main-HASH.js gzip | 6.24 kB | 6.24 kB | ✓ |
| webpack-HASH.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..c6c1.js gzip | 10.1 kB | 10.1 kB | ✓ |
| framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 56.2 kB | 56.2 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| main-HASH.module.js gzip | 4.78 kB | 4.78 kB | ✓ |
| webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..dule.js gzip | 6.71 kB | 6.71 kB | ✓ |
| framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 51.4 kB | 51.4 kB | ✓ |
Legacy Client Bundles (polyfills)
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 26.3 kB | 26.3 kB | ✓ |
| Overall change | 26.3 kB | 26.3 kB | ✓ |
Client Pages
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| _app.js gzip | 1.24 kB | 1.24 kB | ✓ |
| _error.js gzip | 3.15 kB | 3.15 kB | ✓ |
| hooks.js gzip | 664 B | 664 B | ✓ |
| index.js gzip | 222 B | 222 B | ✓ |
| link.js gzip | 2.03 kB | 2.03 kB | ✓ |
| routerDirect.js gzip | 279 B | 279 B | ✓ |
| withRouter.js gzip | 278 B | 278 B | ✓ |
| Overall change | 7.86 kB | 7.86 kB | ✓ |
Client Pages Modern
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| _app.module.js gzip | 594 B | 594 B | ✓ |
| _error.module.js gzip | 2.08 kB | 2.08 kB | ✓ |
| hooks.module.js gzip | 370 B | 370 B | ✓ |
| index.module.js gzip | 212 B | 212 B | ✓ |
| link.module.js gzip | 1.48 kB | 1.48 kB | ✓ |
| routerDirect..dule.js gzip | 271 B | 271 B | ✓ |
| withRouter.m..dule.js gzip | 270 B | 270 B | ✓ |
| Overall change | 5.28 kB | 5.28 kB | ✓ |
Client Build Manifests
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 61 B | 61 B | ✓ |
| _buildManife..dule.js gzip | 61 B | 61 B | ✓ |
| Overall change | 122 B | 122 B | ✓ |
Serverless bundles Overall increase ⚠️
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| _error.js gzip | 293 kB | 293 kB | |
| 404.html gzip | 1.32 kB | 1.32 kB | ✓ |
| hooks.html gzip | 957 B | 957 B | ✓ |
| index.js gzip | 293 kB | 294 kB | |
| link.js gzip | 301 kB | 302 kB | |
| routerDirect.js gzip | 299 kB | 300 kB | |
| withRouter.js gzip | 300 kB | 300 kB | -291 B |
| Overall change | 1.49 MB | 1.49 MB |
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless Mode (Increase detected
|
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| buildDuration | 11.1s | 11.1s | |
| nodeModulesSize | 53 MB | 53 MB | ✓ |
Client Bundles (main, webpack, commons)
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| main-HASH.js gzip | 6.24 kB | 6.24 kB | ✓ |
| webpack-HASH.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..c6c1.js gzip | 10.1 kB | 10.1 kB | ✓ |
| framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 56.2 kB | 56.2 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| main-HASH.module.js gzip | 4.78 kB | 4.78 kB | ✓ |
| webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..dule.js gzip | 6.71 kB | 6.71 kB | ✓ |
| framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 51.4 kB | 51.4 kB | ✓ |
Legacy Client Bundles (polyfills)
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 26.3 kB | 26.3 kB | ✓ |
| Overall change | 26.3 kB | 26.3 kB | ✓ |
Client Pages
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| _app.js gzip | 1.24 kB | 1.24 kB | ✓ |
| _error.js gzip | 3.15 kB | 3.15 kB | ✓ |
| hooks.js gzip | 664 B | 664 B | ✓ |
| index.js gzip | 222 B | 222 B | ✓ |
| link.js gzip | 2.03 kB | 2.03 kB | ✓ |
| routerDirect.js gzip | 279 B | 279 B | ✓ |
| withRouter.js gzip | 278 B | 278 B | ✓ |
| Overall change | 7.86 kB | 7.86 kB | ✓ |
Client Pages Modern
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| _app.module.js gzip | 594 B | 594 B | ✓ |
| _error.module.js gzip | 2.08 kB | 2.08 kB | ✓ |
| hooks.module.js gzip | 370 B | 370 B | ✓ |
| index.module.js gzip | 212 B | 212 B | ✓ |
| link.module.js gzip | 1.48 kB | 1.48 kB | ✓ |
| routerDirect..dule.js gzip | 271 B | 271 B | ✓ |
| withRouter.m..dule.js gzip | 270 B | 270 B | ✓ |
| Overall change | 5.28 kB | 5.28 kB | ✓ |
Client Build Manifests
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 61 B | 61 B | ✓ |
| _buildManife..dule.js gzip | 61 B | 61 B | ✓ |
| Overall change | 122 B | 122 B | ✓ |
Serverless bundles Overall increase ⚠️
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| _error.js gzip | 294 kB | 293 kB | -830 B |
| 404.html gzip | 1.32 kB | 1.32 kB | ✓ |
| hooks.html gzip | 957 B | 957 B | ✓ |
| index.js gzip | 294 kB | 294 kB | |
| link.js gzip | 302 kB | 301 kB | -246 B |
| routerDirect.js gzip | 299 kB | 300 kB | |
| withRouter.js gzip | 299 kB | 300 kB | |
| Overall change | 1.49 MB | 1.49 MB |
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless Mode (Decrease detected ✓)General
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Serverless bundles Overall decrease ✓
|
hoangvvo
force-pushed
the
example-next-connect-passport
branch
from
89d9df9
to
998585b
Compare
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless Mode (Decrease detected ✓)General
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Serverless bundles Overall decrease ✓
|
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless Mode (Increase detected
|
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| buildDuration | 10.8s | 10.7s | -30ms |
| nodeModulesSize | 53 MB | 53 MB | ✓ |
Client Bundles (main, webpack, commons)
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| main-HASH.js gzip | 6.24 kB | 6.24 kB | ✓ |
| webpack-HASH.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..c6c1.js gzip | 10.1 kB | 10.1 kB | ✓ |
| framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 56.2 kB | 56.2 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| main-HASH.module.js gzip | 4.78 kB | 4.78 kB | ✓ |
| webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..dule.js gzip | 6.71 kB | 6.71 kB | ✓ |
| framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 51.4 kB | 51.4 kB | ✓ |
Legacy Client Bundles (polyfills)
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 26.3 kB | 26.3 kB | ✓ |
| Overall change | 26.3 kB | 26.3 kB | ✓ |
Client Pages
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| _app.js gzip | 1.24 kB | 1.24 kB | ✓ |
| _error.js gzip | 3.15 kB | 3.15 kB | ✓ |
| hooks.js gzip | 664 B | 664 B | ✓ |
| index.js gzip | 222 B | 222 B | ✓ |
| link.js gzip | 2.03 kB | 2.03 kB | ✓ |
| routerDirect.js gzip | 279 B | 279 B | ✓ |
| withRouter.js gzip | 278 B | 278 B | ✓ |
| Overall change | 7.86 kB | 7.86 kB | ✓ |
Client Pages Modern
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| _app.module.js gzip | 594 B | 594 B | ✓ |
| _error.module.js gzip | 2.08 kB | 2.08 kB | ✓ |
| hooks.module.js gzip | 370 B | 370 B | ✓ |
| index.module.js gzip | 212 B | 212 B | ✓ |
| link.module.js gzip | 1.48 kB | 1.48 kB | ✓ |
| routerDirect..dule.js gzip | 271 B | 271 B | ✓ |
| withRouter.m..dule.js gzip | 270 B | 270 B | ✓ |
| Overall change | 5.28 kB | 5.28 kB | ✓ |
Client Build Manifests
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 61 B | 61 B | ✓ |
| _buildManife..dule.js gzip | 61 B | 61 B | ✓ |
| Overall change | 122 B | 122 B | ✓ |
Serverless bundles Overall increase ⚠️
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| _error.js gzip | 294 kB | 294 kB | |
| 404.html gzip | 1.32 kB | 1.32 kB | ✓ |
| hooks.html gzip | 957 B | 957 B | ✓ |
| index.js gzip | 294 kB | 294 kB | -213 B |
| link.js gzip | 301 kB | 301 kB | |
| routerDirect.js gzip | 299 kB | 300 kB | |
| withRouter.js gzip | 299 kB | 300 kB | |
| Overall change | 1.49 MB | 1.49 MB |
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless Mode (Increase detected
|
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| buildDuration | 11.6s | 11.6s | |
| nodeModulesSize | 53 MB | 53 MB | ✓ |
Client Bundles (main, webpack, commons)
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| main-HASH.js gzip | 6.24 kB | 6.24 kB | ✓ |
| webpack-HASH.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..c6c1.js gzip | 10.1 kB | 10.1 kB | ✓ |
| framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 56.2 kB | 56.2 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| main-HASH.module.js gzip | 4.78 kB | 4.78 kB | ✓ |
| webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..dule.js gzip | 6.71 kB | 6.71 kB | ✓ |
| framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 51.4 kB | 51.4 kB | ✓ |
Legacy Client Bundles (polyfills)
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 26.3 kB | 26.3 kB | ✓ |
| Overall change | 26.3 kB | 26.3 kB | ✓ |
Client Pages
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| _app.js gzip | 1.24 kB | 1.24 kB | ✓ |
| _error.js gzip | 3.15 kB | 3.15 kB | ✓ |
| hooks.js gzip | 664 B | 664 B | ✓ |
| index.js gzip | 222 B | 222 B | ✓ |
| link.js gzip | 2.03 kB | 2.03 kB | ✓ |
| routerDirect.js gzip | 279 B | 279 B | ✓ |
| withRouter.js gzip | 278 B | 278 B | ✓ |
| Overall change | 7.86 kB | 7.86 kB | ✓ |
Client Pages Modern
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| _app.module.js gzip | 594 B | 594 B | ✓ |
| _error.module.js gzip | 2.08 kB | 2.08 kB | ✓ |
| hooks.module.js gzip | 370 B | 370 B | ✓ |
| index.module.js gzip | 212 B | 212 B | ✓ |
| link.module.js gzip | 1.48 kB | 1.48 kB | ✓ |
| routerDirect..dule.js gzip | 271 B | 271 B | ✓ |
| withRouter.m..dule.js gzip | 270 B | 270 B | ✓ |
| Overall change | 5.28 kB | 5.28 kB | ✓ |
Client Build Manifests
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 61 B | 61 B | ✓ |
| _buildManife..dule.js gzip | 61 B | 61 B | ✓ |
| Overall change | 122 B | 122 B | ✓ |
Serverless bundles Overall increase ⚠️
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| _error.js gzip | 293 kB | 294 kB | |
| 404.html gzip | 1.32 kB | 1.32 kB | ✓ |
| hooks.html gzip | 959 B | 959 B | ✓ |
| index.js gzip | 293 kB | 294 kB | |
| link.js gzip | 302 kB | 302 kB | |
| routerDirect.js gzip | 300 kB | 300 kB | |
| withRouter.js gzip | 300 kB | 300 kB | |
| Overall change | 1.49 MB | 1.49 MB |
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless Mode (Decrease detected ✓)General
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Serverless bundles Overall decrease ✓
|
lfades
reviewed
Mar 27, 2020
| keys: ['hackme'], | ||
| }) | ||
| ) | ||
| .use(passport.initialize()) |
There was a problem hiding this comment.
Wait does this mean Passport doesn't have to be used with Express? That's very interesting 🤔
There was a problem hiding this comment.
Not at all. It can totally be used with good ol' connect, except passport uses res.redirect helper which is only available in express.
next-connect is pretty much connect (hence its name), but with router, sub-application. Yet, it is even 10 times smaller than connect in install size.
There was a problem hiding this comment.
Pretty nice, in that case the with-passport example deserves an update, I want to get rid of Express for the smallest thing in the world!, that can work with the auth plugins for passport like google, github, etc, what do you think is the best alternative?
There was a problem hiding this comment.
I believe our guide in https://nextjs.org/docs/api-routes/api-middlewares will do just fine. Can I give it a try? 😄
lfades
requested changes
Mar 27, 2020
There was a problem hiding this comment.
Hi @hoangvvo Thank you for the PR, I took a look into next-connect and it looks good to me, this is what a I want to change:
- Rename the example to
with-next-connect-and-passport, or towith-passport-and-next-connect - Use the styling and html of the with-passport example, reason for that is that template, although not exactly beautiful, is being used for auth examples.
- Remove anything that's not related to the auth with passport and next-connect, so for example the posts and other stuff that make the example bigger and more complex. I'm still not sure about this last one so you're welcome to disagree, but overall I think the example should focus on passport and next-connect only.
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless Mode (Decrease detected ✓)General
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Serverless bundles Overall decrease ✓
|
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless Mode (Increase detected
|
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| buildDuration | 10.9s | 11.2s | |
| nodeModulesSize | 52.8 MB | 52.8 MB | ✓ |
Client Bundles (main, webpack, commons)
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| main-HASH.js gzip | 6.24 kB | 6.24 kB | ✓ |
| webpack-HASH.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..c6c1.js gzip | 10.1 kB | 10.1 kB | ✓ |
| framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 56.2 kB | 56.2 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| main-HASH.module.js gzip | 4.77 kB | 4.77 kB | ✓ |
| webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..dule.js gzip | 6.71 kB | 6.71 kB | ✓ |
| framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 51.4 kB | 51.4 kB | ✓ |
Legacy Client Bundles (polyfills)
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 26.3 kB | 26.3 kB | ✓ |
| Overall change | 26.3 kB | 26.3 kB | ✓ |
Client Pages
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| _app.js gzip | 1.24 kB | 1.24 kB | ✓ |
| _error.js gzip | 3.15 kB | 3.15 kB | ✓ |
| hooks.js gzip | 664 B | 664 B | ✓ |
| index.js gzip | 222 B | 222 B | ✓ |
| link.js gzip | 2.03 kB | 2.03 kB | ✓ |
| routerDirect.js gzip | 279 B | 279 B | ✓ |
| withRouter.js gzip | 278 B | 278 B | ✓ |
| Overall change | 7.86 kB | 7.86 kB | ✓ |
Client Pages Modern
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| _app.module.js gzip | 594 B | 594 B | ✓ |
| _error.module.js gzip | 2.08 kB | 2.08 kB | ✓ |
| hooks.module.js gzip | 370 B | 370 B | ✓ |
| index.module.js gzip | 212 B | 212 B | ✓ |
| link.module.js gzip | 1.48 kB | 1.48 kB | ✓ |
| routerDirect..dule.js gzip | 271 B | 271 B | ✓ |
| withRouter.m..dule.js gzip | 270 B | 270 B | ✓ |
| Overall change | 5.28 kB | 5.28 kB | ✓ |
Client Build Manifests
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 61 B | 61 B | ✓ |
| _buildManife..dule.js gzip | 61 B | 61 B | ✓ |
| Overall change | 122 B | 122 B | ✓ |
Serverless bundles Overall increase ⚠️
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| _error.js gzip | 294 kB | 294 kB | |
| 404.html gzip | 1.32 kB | 1.32 kB | ✓ |
| hooks.html gzip | 958 B | 958 B | ✓ |
| index.js gzip | 294 kB | 294 kB | -335 B |
| link.js gzip | 302 kB | 302 kB | |
| routerDirect.js gzip | 300 kB | 300 kB | |
| withRouter.js gzip | 300 kB | 300 kB | -22 B |
| Overall change | 1.49 MB | 1.49 MB |
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless Mode (Increase detected
|
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| buildDuration | 11.3s | 11.3s | |
| nodeModulesSize | 52.8 MB | 52.8 MB | ✓ |
Client Bundles (main, webpack, commons)
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| main-HASH.js gzip | 6.24 kB | 6.24 kB | ✓ |
| webpack-HASH.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..c6c1.js gzip | 10.1 kB | 10.1 kB | ✓ |
| framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 56.2 kB | 56.2 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| main-HASH.module.js gzip | 4.77 kB | 4.77 kB | ✓ |
| webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..dule.js gzip | 6.71 kB | 6.71 kB | ✓ |
| framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 51.4 kB | 51.4 kB | ✓ |
Legacy Client Bundles (polyfills)
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 26.3 kB | 26.3 kB | ✓ |
| Overall change | 26.3 kB | 26.3 kB | ✓ |
Client Pages
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| _app.js gzip | 1.24 kB | 1.24 kB | ✓ |
| _error.js gzip | 3.15 kB | 3.15 kB | ✓ |
| hooks.js gzip | 664 B | 664 B | ✓ |
| index.js gzip | 222 B | 222 B | ✓ |
| link.js gzip | 2.03 kB | 2.03 kB | ✓ |
| routerDirect.js gzip | 279 B | 279 B | ✓ |
| withRouter.js gzip | 278 B | 278 B | ✓ |
| Overall change | 7.86 kB | 7.86 kB | ✓ |
Client Pages Modern
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| _app.module.js gzip | 594 B | 594 B | ✓ |
| _error.module.js gzip | 2.08 kB | 2.08 kB | ✓ |
| hooks.module.js gzip | 370 B | 370 B | ✓ |
| index.module.js gzip | 212 B | 212 B | ✓ |
| link.module.js gzip | 1.48 kB | 1.48 kB | ✓ |
| routerDirect..dule.js gzip | 271 B | 271 B | ✓ |
| withRouter.m..dule.js gzip | 270 B | 270 B | ✓ |
| Overall change | 5.28 kB | 5.28 kB | ✓ |
Client Build Manifests
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 61 B | 61 B | ✓ |
| _buildManife..dule.js gzip | 61 B | 61 B | ✓ |
| Overall change | 122 B | 122 B | ✓ |
Serverless bundles Overall increase ⚠️
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| _error.js gzip | 294 kB | 294 kB | |
| 404.html gzip | 1.32 kB | 1.32 kB | ✓ |
| hooks.html gzip | 958 B | 958 B | ✓ |
| index.js gzip | 293 kB | 293 kB | |
| link.js gzip | 301 kB | 301 kB | |
| routerDirect.js gzip | 300 kB | 300 kB | -3 B |
| withRouter.js gzip | 300 kB | 300 kB | |
| Overall change | 1.49 MB | 1.49 MB |
|
@hoangvvo "This example does not really focus on security, it is merely demonstrative. It is nowhere near Auth is very important in many applications, it's also very dangerous if you don't do it properly. We like to provide high quality standards in our examples, so we can recommend them to the community, and security is not negotiable. We even recommend Please apply the setup in You already helped us with this PR even though it's not yet merged: #11747 |
|
@lfades I certainly agree. I have updated the example to use |
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless Mode (Increase detected
|
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| buildDuration | 10.4s | 10.4s | |
| nodeModulesSize | 52.5 MB | 52.5 MB | ✓ |
Client Bundles (main, webpack, commons)
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| main-HASH.js gzip | 6.25 kB | 6.25 kB | ✓ |
| webpack-HASH.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..e3d8.js gzip | 10.2 kB | 10.2 kB | ✓ |
| framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 56.3 kB | 56.3 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| main-HASH.module.js gzip | 4.78 kB | 4.78 kB | ✓ |
| webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..dule.js gzip | 6.78 kB | 6.78 kB | ✓ |
| framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 51.5 kB | 51.5 kB | ✓ |
Legacy Client Bundles (polyfills)
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 26.3 kB | 26.3 kB | ✓ |
| Overall change | 26.3 kB | 26.3 kB | ✓ |
Client Pages
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| _app.js gzip | 1.24 kB | 1.24 kB | ✓ |
| _error.js gzip | 3.15 kB | 3.15 kB | ✓ |
| hooks.js gzip | 664 B | 664 B | ✓ |
| index.js gzip | 222 B | 222 B | ✓ |
| link.js gzip | 2.03 kB | 2.03 kB | ✓ |
| routerDirect.js gzip | 279 B | 279 B | ✓ |
| withRouter.js gzip | 278 B | 278 B | ✓ |
| Overall change | 7.86 kB | 7.86 kB | ✓ |
Client Pages Modern
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| _app.module.js gzip | 594 B | 594 B | ✓ |
| _error.module.js gzip | 2.08 kB | 2.08 kB | ✓ |
| hooks.module.js gzip | 370 B | 370 B | ✓ |
| index.module.js gzip | 212 B | 212 B | ✓ |
| link.module.js gzip | 1.48 kB | 1.48 kB | ✓ |
| routerDirect..dule.js gzip | 271 B | 271 B | ✓ |
| withRouter.m..dule.js gzip | 270 B | 270 B | ✓ |
| Overall change | 5.28 kB | 5.28 kB | ✓ |
Client Build Manifests
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 61 B | 61 B | ✓ |
| _buildManife..dule.js gzip | 61 B | 61 B | ✓ |
| Overall change | 122 B | 122 B | ✓ |
Serverless bundles Overall increase ⚠️
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| _error.js gzip | 233 kB | 233 kB | -5 B |
| 404.html gzip | 1.32 kB | 1.32 kB | ✓ |
| hooks.html gzip | 956 B | 956 B | ✓ |
| index.js gzip | 233 kB | 233 kB | |
| link.js gzip | 243 kB | 243 kB | -70 B |
| routerDirect.js gzip | 241 kB | 241 kB | -34 B |
| withRouter.js gzip | 241 kB | 241 kB | |
| Overall change | 1.19 MB | 1.19 MB |
…angvvo/next.js into example-next-connect-passport
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless Mode (Increase detected
|
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| buildDuration | 12.1s | 12s | -172ms |
| nodeModulesSize | 52.5 MB | 52.5 MB | ✓ |
Client Bundles (main, webpack, commons)
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| main-HASH.js gzip | 6.25 kB | 6.25 kB | ✓ |
| webpack-HASH.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..e3d8.js gzip | 10.2 kB | 10.2 kB | ✓ |
| framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 56.3 kB | 56.3 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| main-HASH.module.js gzip | 4.78 kB | 4.78 kB | ✓ |
| webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..dule.js gzip | 6.78 kB | 6.78 kB | ✓ |
| framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 51.5 kB | 51.5 kB | ✓ |
Legacy Client Bundles (polyfills)
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 26.3 kB | 26.3 kB | ✓ |
| Overall change | 26.3 kB | 26.3 kB | ✓ |
Client Pages
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| _app.js gzip | 1.24 kB | 1.24 kB | ✓ |
| _error.js gzip | 3.15 kB | 3.15 kB | ✓ |
| hooks.js gzip | 664 B | 664 B | ✓ |
| index.js gzip | 222 B | 222 B | ✓ |
| link.js gzip | 2.03 kB | 2.03 kB | ✓ |
| routerDirect.js gzip | 279 B | 279 B | ✓ |
| withRouter.js gzip | 278 B | 278 B | ✓ |
| Overall change | 7.86 kB | 7.86 kB | ✓ |
Client Pages Modern
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| _app.module.js gzip | 594 B | 594 B | ✓ |
| _error.module.js gzip | 2.08 kB | 2.08 kB | ✓ |
| hooks.module.js gzip | 370 B | 370 B | ✓ |
| index.module.js gzip | 212 B | 212 B | ✓ |
| link.module.js gzip | 1.48 kB | 1.48 kB | ✓ |
| routerDirect..dule.js gzip | 271 B | 271 B | ✓ |
| withRouter.m..dule.js gzip | 270 B | 270 B | ✓ |
| Overall change | 5.28 kB | 5.28 kB | ✓ |
Client Build Manifests
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 61 B | 61 B | ✓ |
| _buildManife..dule.js gzip | 61 B | 61 B | ✓ |
| Overall change | 122 B | 122 B | ✓ |
Serverless bundles Overall increase ⚠️
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| _error.js gzip | 233 kB | 233 kB | ✓ |
| 404.html gzip | 1.32 kB | 1.32 kB | ✓ |
| hooks.html gzip | 956 B | 956 B | ✓ |
| index.js gzip | 233 kB | 233 kB | |
| link.js gzip | 243 kB | 243 kB | -79 B |
| routerDirect.js gzip | 241 kB | 241 kB | |
| withRouter.js gzip | 241 kB | 241 kB | -52 B |
| Overall change | 1.19 MB | 1.19 MB |
|
This example now also use |
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless Mode (Decrease detected ✓)General
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Serverless bundles Overall decrease ✓
|
|
DB related functions are now abstracted in a single so people can easily implement their db |
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless Mode (Increase detected
|
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| buildDuration | 11.3s | 11.3s | |
| nodeModulesSize | 52.5 MB | 52.5 MB | ✓ |
Client Bundles (main, webpack, commons)
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| main-HASH.js gzip | 6.25 kB | 6.25 kB | ✓ |
| webpack-HASH.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..e3d8.js gzip | 10.2 kB | 10.2 kB | ✓ |
| framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 56.3 kB | 56.3 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| main-HASH.module.js gzip | 4.78 kB | 4.78 kB | ✓ |
| webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..dule.js gzip | 6.78 kB | 6.78 kB | ✓ |
| framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 51.5 kB | 51.5 kB | ✓ |
Legacy Client Bundles (polyfills)
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 26.3 kB | 26.3 kB | ✓ |
| Overall change | 26.3 kB | 26.3 kB | ✓ |
Client Pages
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| _app.js gzip | 1.24 kB | 1.24 kB | ✓ |
| _error.js gzip | 3.15 kB | 3.15 kB | ✓ |
| hooks.js gzip | 664 B | 664 B | ✓ |
| index.js gzip | 222 B | 222 B | ✓ |
| link.js gzip | 2.03 kB | 2.03 kB | ✓ |
| routerDirect.js gzip | 279 B | 279 B | ✓ |
| withRouter.js gzip | 278 B | 278 B | ✓ |
| Overall change | 7.86 kB | 7.86 kB | ✓ |
Client Pages Modern
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| _app.module.js gzip | 594 B | 594 B | ✓ |
| _error.module.js gzip | 2.08 kB | 2.08 kB | ✓ |
| hooks.module.js gzip | 370 B | 370 B | ✓ |
| index.module.js gzip | 212 B | 212 B | ✓ |
| link.module.js gzip | 1.48 kB | 1.48 kB | ✓ |
| routerDirect..dule.js gzip | 271 B | 271 B | ✓ |
| withRouter.m..dule.js gzip | 270 B | 270 B | ✓ |
| Overall change | 5.28 kB | 5.28 kB | ✓ |
Client Build Manifests
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 61 B | 61 B | ✓ |
| _buildManife..dule.js gzip | 61 B | 61 B | ✓ |
| Overall change | 122 B | 122 B | ✓ |
Serverless bundles Overall increase ⚠️
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| _error.js gzip | 233 kB | 233 kB | |
| 404.html gzip | 1.32 kB | 1.32 kB | ✓ |
| hooks.html gzip | 956 B | 956 B | ✓ |
| index.js gzip | 233 kB | 233 kB | |
| link.js gzip | 243 kB | 243 kB | -82 B |
| routerDirect.js gzip | 241 kB | 241 kB | |
| withRouter.js gzip | 241 kB | 241 kB | |
| Overall change | 1.19 MB | 1.19 MB |
|
✔️ 🔒 Add more notes on password hashing |
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless Mode (Increase detected
|
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| buildDuration | 11.5s | 11.4s | -178ms |
| nodeModulesSize | 52.5 MB | 52.5 MB | ✓ |
Client Bundles (main, webpack, commons)
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| main-HASH.js gzip | 6.25 kB | 6.25 kB | ✓ |
| webpack-HASH.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..e3d8.js gzip | 10.2 kB | 10.2 kB | ✓ |
| framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 56.3 kB | 56.3 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| main-HASH.module.js gzip | 4.78 kB | 4.78 kB | ✓ |
| webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..dule.js gzip | 6.78 kB | 6.78 kB | ✓ |
| framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 51.5 kB | 51.5 kB | ✓ |
Legacy Client Bundles (polyfills)
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 26.3 kB | 26.3 kB | ✓ |
| Overall change | 26.3 kB | 26.3 kB | ✓ |
Client Pages
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| _app.js gzip | 1.24 kB | 1.24 kB | ✓ |
| _error.js gzip | 3.15 kB | 3.15 kB | ✓ |
| hooks.js gzip | 664 B | 664 B | ✓ |
| index.js gzip | 222 B | 222 B | ✓ |
| link.js gzip | 2.03 kB | 2.03 kB | ✓ |
| routerDirect.js gzip | 279 B | 279 B | ✓ |
| withRouter.js gzip | 278 B | 278 B | ✓ |
| Overall change | 7.86 kB | 7.86 kB | ✓ |
Client Pages Modern
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| _app.module.js gzip | 594 B | 594 B | ✓ |
| _error.module.js gzip | 2.08 kB | 2.08 kB | ✓ |
| hooks.module.js gzip | 370 B | 370 B | ✓ |
| index.module.js gzip | 212 B | 212 B | ✓ |
| link.module.js gzip | 1.48 kB | 1.48 kB | ✓ |
| routerDirect..dule.js gzip | 271 B | 271 B | ✓ |
| withRouter.m..dule.js gzip | 270 B | 270 B | ✓ |
| Overall change | 5.28 kB | 5.28 kB | ✓ |
Client Build Manifests
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 61 B | 61 B | ✓ |
| _buildManife..dule.js gzip | 61 B | 61 B | ✓ |
| Overall change | 122 B | 122 B | ✓ |
Serverless bundles Overall increase ⚠️
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| _error.js gzip | 233 kB | 233 kB | |
| 404.html gzip | 1.32 kB | 1.32 kB | ✓ |
| hooks.html gzip | 956 B | 956 B | ✓ |
| index.js gzip | 233 kB | 233 kB | -187 B |
| link.js gzip | 243 kB | 243 kB | |
| routerDirect.js gzip | 241 kB | 241 kB | -61 B |
| withRouter.js gzip | 241 kB | 241 kB | |
| Overall change | 1.19 MB | 1.19 MB |
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless Mode (Decrease detected ✓)General
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Serverless bundles Overall decrease ✓
|
Stats from current PRDefault Server ModeGeneral
Client Bundles (main, webpack, commons)
Client Bundles (main, webpack, commons) Modern
Legacy Client Bundles (polyfills)
Client Pages
Client Pages Modern
Client Build Manifests
Rendered Page Sizes
Serverless Mode (Increase detected
|
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| buildDuration | 9.5s | 9.5s | |
| nodeModulesSize | 52.5 MB | 52.5 MB | ✓ |
Client Bundles (main, webpack, commons)
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| main-HASH.js gzip | 6.25 kB | 6.25 kB | ✓ |
| webpack-HASH.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..e3d8.js gzip | 10.2 kB | 10.2 kB | ✓ |
| framework.HASH.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 56.3 kB | 56.3 kB | ✓ |
Client Bundles (main, webpack, commons) Modern
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| main-HASH.module.js gzip | 4.78 kB | 4.78 kB | ✓ |
| webpack-HASH..dule.js gzip | 746 B | 746 B | ✓ |
| de003c3a9d30..dule.js gzip | 6.78 kB | 6.78 kB | ✓ |
| framework.HA..dule.js gzip | 39.1 kB | 39.1 kB | ✓ |
| Overall change | 51.5 kB | 51.5 kB | ✓ |
Legacy Client Bundles (polyfills)
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 26.3 kB | 26.3 kB | ✓ |
| Overall change | 26.3 kB | 26.3 kB | ✓ |
Client Pages
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| _app.js gzip | 1.24 kB | 1.24 kB | ✓ |
| _error.js gzip | 3.15 kB | 3.15 kB | ✓ |
| hooks.js gzip | 664 B | 664 B | ✓ |
| index.js gzip | 222 B | 222 B | ✓ |
| link.js gzip | 2.03 kB | 2.03 kB | ✓ |
| routerDirect.js gzip | 279 B | 279 B | ✓ |
| withRouter.js gzip | 278 B | 278 B | ✓ |
| Overall change | 7.86 kB | 7.86 kB | ✓ |
Client Pages Modern
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| _app.module.js gzip | 594 B | 594 B | ✓ |
| _error.module.js gzip | 2.08 kB | 2.08 kB | ✓ |
| hooks.module.js gzip | 370 B | 370 B | ✓ |
| index.module.js gzip | 212 B | 212 B | ✓ |
| link.module.js gzip | 1.48 kB | 1.48 kB | ✓ |
| routerDirect..dule.js gzip | 271 B | 271 B | ✓ |
| withRouter.m..dule.js gzip | 270 B | 270 B | ✓ |
| Overall change | 5.28 kB | 5.28 kB | ✓ |
Client Build Manifests
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 61 B | 61 B | ✓ |
| _buildManife..dule.js gzip | 61 B | 61 B | ✓ |
| Overall change | 122 B | 122 B | ✓ |
Serverless bundles Overall increase ⚠️
| zeit/next.js canary | hoangvvo/next.js example-next-connect-passport | Change | |
|---|---|---|---|
| _error.js gzip | 233 kB | 233 kB | -25 B |
| 404.html gzip | 1.32 kB | 1.32 kB | ✓ |
| hooks.html gzip | 956 B | 956 B | ✓ |
| index.js gzip | 233 kB | 233 kB | |
| link.js gzip | 243 kB | 243 kB | -25 B |
| routerDirect.js gzip | 241 kB | 241 kB | -2 B |
| withRouter.js gzip | 241 kB | 241 kB | |
| Overall change | 1.19 MB | 1.19 MB |
This was referenced Apr 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This example creates a basic app with authentication and CRUD (User can create new posts and edit, delete such posts after being authenticated).
Using my library next-connect for easier REST API and middleware implementation. (1/50 the size of Express.js)
Authentication is handled by passport and cookie-session. The "posts database" is mocked with the cookie session.