Splat listen() args to only specify host when supplied #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TooTallNate
reviewed
Mar 10, 2018
| @@ -101,7 +100,12 @@ async function start() { | |||
| process.exit(1) | |||
| }) | |||
|
|
|||
| server.listen(flags.port, flags.host, () => { | |||
| const listenArgs = [flags.port || 0] | |||
There was a problem hiding this comment.
How would port be falsy if we default it to 3000?
There was a problem hiding this comment.
@TooTallNate empty string. I expected the option parser to accept an empty string as 'valid' and not use it as an excuse to fallback to default (where, instead, it should only populate the default if the -p option was never encountered at all).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This more strictly abides by the contract that a non-specified host in the
listen()call might behave differently if the system is running IPv4 vs IPv6 as per the documentation (since the documentation doesn't specify exactly what happens on an IPv4 system with'::').