Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert ignored string to regex #54

Merged
merged 1 commit into from Dec 4, 2017
Merged

Convert ignored string to regex #54

merged 1 commit into from Dec 4, 2017

Conversation

zigomir
Copy link
Contributor

@zigomir zigomir commented Dec 3, 2017

I'm using JetBrains editor and I wanted to pass --ignore .idea to micro-dev and it would still restart server on every focus lost of the editor. To be able to really ignore the directory we'd need to convert .idea string into regex. This change solves my issue, but I'm not so sure about other use cases.

Otherwise ignore won't work.
@leo leo merged commit f1a1997 into vercel:master Dec 4, 2017
@tungv tungv mentioned this pull request Feb 1, 2018
@tungv
Copy link
Contributor

tungv commented Feb 1, 2018

after this PR, ** globs stop working since it's not a valid regexp.

I think we should reserve anymatch semantics and adding a different flag for regexp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants