Rule proposal: no-useless-scu

[nkt]

shouldComponentUpdate method is useless when component extending PureComponent.

[ljharb]

It's worth noting that I think it will actually work - it just means there's no point in it extending PureComponent then. I'm 👍 on this rule.

[jseminck]

I'll take a look at this rule, since it was just recently requested again in #1217

It looks pretty easy to add:

• Validate the MethodDefinition name
• Validate that the method is declared in a PureComponent (for which a helper already exists)

Probably will need some help with the actual rule name and errors + docs. I suppose no-useless-scu is not a good name, as we want to warn the user not to extend React.PureComponent when they want to override shouldComponentUpdate?

[jseminck]

Nevermind. There is a PR already. Missed it.

[alexzherdev]

Fixed via #1084.