New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jsx-sort-props regression breaks callbacksLast option. #1175
Comments
The problem seems to be the combination of
However,
The bug was introduced in 7.0.0. Specifically here - where the check for the 6e18e40#diff-bf26edcfae7aa27411d9a791b4eb8a8eL74 Seems like a simple fix, moving it back to it's original position does not break any tests. Will create a PR that includes a test case containing these two properties as defined options. |
I noticed after upgrading to v7.0.0 of this package that the
jsx-sort-props
rule is no longer honoring mycallbacksLast
flag. Given this hunk of my ESLint configuration......a line like this...
...will yield the following warnings:
My expectation would be that with
callbacksLast
enabled, theshowLogo
prop should appear before theon...
props, which latter should be sorted alphabetically at the end intoonLogoClick
thenonToggleMenu
. Though I could certainly be misunderstanding some change to the rule.Thanks in advance for your help, and let me know if I can furnish any more debugging information!
The text was updated successfully, but these errors were encountered: