Adds more checks to MethodDefinition case and adds new test case for …

…default parser
jsx-eslint · Jan 21, 2018 · 20dff22 · 20dff22
1 parent f9cc10d
commit 20dff22
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 3 deletions.
diff --git a/lib/rules/prop-types.js b/lib/rules/prop-types.js
@@ -607,9 +607,14 @@ module.exports = {
           properties = node.params[0].properties;
           break;
         case 'MethodDefinition':
-          type = 'destructuring';
-          properties = node.value.params[0].properties;
-          break;
+          const destructuring = node.value && node.value.params && node.value.params[0] && node.value.params[0].type === 'ObjectPattern';
+          if (destructuring) {
+            type = 'destructuring';
+            properties = node.value.params[0].properties;
+            break;
+          } else {
+            return;
+          }
         case 'VariableDeclarator':
           for (let i = 0, j = node.id.properties.length; i < j; i++) {
             // let {props: {firstname}} = this

diff --git a/tests/lib/rules/prop-types.js b/tests/lib/rules/prop-types.js
@@ -3115,6 +3115,25 @@ ruleTester.run('prop-types', rule, {
       errors: [
         {message: '\'foo\' is missing in props validation'}
       ]
+    }, {
+      code: [
+        'class Hello extends Component {',
+        '  componentWillReceiveProps({foo}) {',
+        '    if (foo) {',
+        '      return;',
+        '    }',
+        '  }',
+        '  render() {',
+        '    return <div bar={this.props.bar} />;',
+        '  }',
+        '}',
+        'Hello.propTypes = {',
+        '    bar: PropTypes.func',
+        '  }'
+      ].join('\n'),
+      errors: [
+        {message: '\'foo\' is missing in props validation'}
+      ]
     }, {
       code: [
         'class Hello extends React.Component {',