refactor: lookup promise statics from object instead of array (#131)

eslint-community · May 24, 2018 · 9b0cbd1 · 9b0cbd1
1 parent ceb7414
commit 9b0cbd1
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/rules/lib/is-promise.js b/rules/lib/is-promise.js
@@ -29,7 +29,7 @@ function isPromise(expression) {
       expression.callee.type === 'MemberExpression' &&
       expression.callee.object.type === 'Identifier' &&
       expression.callee.object.name === 'Promise' &&
-      PROMISE_STATICS.indexOf(expression.callee.property.name) !== -1)
+      PROMISE_STATICS[expression.callee.property.name])
   )
 }
 

diff --git a/rules/lib/promise-statics.js b/rules/lib/promise-statics.js
@@ -1,3 +1,8 @@
 'use strict'
 
-module.exports = ['all', 'race', 'reject', 'resolve']
+module.exports = {
+  all: true,
+  race: true,
+  reject: true,
+  resolve: true
+}
diff --git a/rules/no-new-statics.js b/rules/no-new-statics.js
@@ -15,7 +15,7 @@ module.exports = {
         if (
           node.callee.type === 'MemberExpression' &&
           node.callee.object.name === 'Promise' &&
-          PROMISE_STATICS.indexOf(node.callee.property.name) > -1
+          PROMISE_STATICS[node.callee.property.name]
         ) {
           context.report({
             node,