Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modified value comments are lost in transformation #2320

Open
idoros opened this issue Feb 8, 2022 · 0 comments
Open

modified value comments are lost in transformation #2320

idoros opened this issue Feb 8, 2022 · 0 comments
Labels
bug Unexpected behavior or exception core Processing and transforming logic

Comments

@idoros
Copy link
Collaborator

idoros commented Feb 8, 2022 •
edited

Stylable loses value comments when they are modified. This is because parsing with postcss removes value comments (the originals are kept under the declaration AST raws field), and Stylable ignores them in case the value is transformed.

Ideally comment should not be touched in transformation and only be removed by an optimizer.

postcss removes value comments
stylable playground example
@idoros idoros added bug Unexpected behavior or exception core Processing and transforming logic labels Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Unexpected behavior or exception core Processing and transforming logic
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@idoros