Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unify exports behavior #2267

Open
idoros opened this issue Jan 16, 2022 · 0 comments
Open

unify exports behavior #2267

idoros opened this issue Jan 16, 2022 · 0 comments
Labels
bug Unexpected behavior or exception core Processing and transforming logic tech debt Updates, upgrades, stale code and work-arounds

Comments

@idoros
Copy link
Collaborator

idoros commented Jan 16, 2022 •
edited

Proposal Description

The current symbols of a stylesheet are mostly automatically exported, until we allow explicit export mode, I suggest we unify the behavior of all symbols.

current issues with import/auto-export symbols:

  • class & type selectors are not automatically exported - exporting them shouldn't break anything
  • type selector transformation bug: MyElement -> .ns__MyElement - fix(core): imported element transform to class #2603
  • imported st-var are not exported to JS - should probably stay the default to keep JS to a minimum and could potentially be explicitly exported when such a feature is available

see playground

related issues:
@idoros idoros added bug Unexpected behavior or exception core Processing and transforming logic tech debt Updates, upgrades, stale code and work-arounds labels Jan 16, 2022
@idoros idoros mentioned this issue Jul 11, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Unexpected behavior or exception core Processing and transforming logic tech debt Updates, upgrades, stale code and work-arounds
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@idoros