Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

If I do not change the position of the separators and set separatorsStyle={{backgroundColor:'green',}}, the text will be obscured. #3028

Open
yinminqian opened this issue Apr 16, 2024 · 1 comment

Comments

@yinminqian
Copy link

Hi! 馃憢

Firstly, thanks for your work on this project! 馃檪

Today I used patch-package to patch react-native-ui-lib@7.20.0 for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-ui-lib/src/components/WheelPicker/index.js b/node_modules/react-native-ui-lib/src/components/WheelPicker/index.js
index eb17b63..d7fdbe2 100644
--- a/node_modules/react-native-ui-lib/src/components/WheelPicker/index.js
+++ b/node_modules/react-native-ui-lib/src/components/WheelPicker/index.js
@@ -204,6 +204,7 @@ const WheelPicker = props => {
   }, []);
   const offsets = useMemo(() => items.map((_, i) => i * itemHeight), [items, itemHeight]);
   return <View testID={testID} bg-$backgroundDefault style={style}>
+      {separators}
       <View row centerH>
         <View flexG>
           <AnimatedFlatList {...androidFlatListProps} {...flatListProps} testID={`${testID}.list`} listKey={`${testID}.flatList`} height={height} data={items}
@@ -219,7 +220,7 @@ const WheelPicker = props => {
       {label && labelContainer}
       {fader(FaderPosition.BOTTOM)}
       {fader(FaderPosition.TOP)}
-      {separators}
+
     </View>;
 };
 WheelPicker.alignments = WheelPickerAlign;

This issue body was partially generated by patch-package.

image image
@d-moreira
Copy link

Facing the same issue. Imo the default behaviour should be the one described here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants