Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend to allow standard websockets #2760

Closed
manicphase opened this issue Mar 9, 2024 · 2 comments
Closed

Extend to allow standard websockets #2760

manicphase opened this issue Mar 9, 2024 · 2 comments

Comments

@manicphase
Copy link
Contributor

What version of this package are you using?
2.1.37

What problem do you want to solve?
Make it easier to push files to a headless server from the browser.
Simultaneously send files to workers (ie, peertube-runners) before upload is finished.
Resumable uploads.

What do you think is the correct solution to this problem?
Webrtc still seems too flaky to be relied upon in webtorrent-hybrid. Extend Webtorrent to have WebsocketServer and WebsocketClient as new peer types. This way the server is guaranteed to be able to download from at least one peer in the swarm.

Are you willing to submit a pull request to implement this change?
Yes, but I'd need advice on where to make changes. (Should it be webtorrent/lib or bittorrent-protocol or somewhere else?)

@ThaUnknown
Copy link
Member

while this is unironically a good suggestion, it's gonna be difficult to implement a new peer type, which would still be undocumented, same as the current webrtc peer for webtorrent, which after all these years isn't documented lol, but +1

Copy link

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@github-actions github-actions bot added the stale label May 14, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants