Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

download event getting triggered after done #2143

Open
alxhotel opened this issue Jul 21, 2021 · 2 comments
Open

download event getting triggered after done #2143

alxhotel opened this issue Jul 21, 2021 · 2 comments
Assignees
@alxhotel
Labels
accepted

Comments

@alxhotel
Copy link
Member

alxhotel commented Jul 21, 2021 •
edited

What version of this package are you using?
1.2.5
What operating system, Node.js, and npm version?
Node 16.4.1
NPM 7.18.1

What happened?
The download event of the torrent and client are being triggered even when the torrent is fully downloaded.

I'm not sure if this is the intended use, but if it is we should write that in the docs.

This issue was found in #1984

What did you expect to happen?
We need to figure this out.

Are you willing to submit a pull request to fix this bug?
@alxhotel alxhotel changed the title done event getting triggered after done download event getting triggered after done Jul 21, 2021
@alxhotel alxhotel self-assigned this Jul 21, 2021
@alxhotel alxhotel mentioned this issue Jul 21, 2021
Closed
@github-actions
Copy link

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@github-actions github-actions bot added the stale label Sep 20, 2021
@alxhotel alxhotel added accepted and removed stale labels Sep 20, 2021
@ftreesmilo
Copy link
Contributor

I think this is related to my recent issue #2486

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alxhotel alxhotel

Labels
accepted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alxhotel @ftreesmilo