Change WebSocket#{p{i,o}ng,send}() behavior
#1532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpinca
force-pushed
the
gh-1515
branch
2 times, most recently
from
435fdcb
to
17a8e7b
Compare
- If the `readyState` attribute is `CONNECTING`, throw an exception.
- If the `readyState` attribute is `CLOSING` or `CLOSED`
- Increase the `bufferedAmount` attribute by the length of the `data`
argument in bytes.
- If specified, call the `callback` function with an error.
Fixes #1515
This was referenced Nov 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
readyStateattribute isCONNECTING, throw an exception.readyStateattribute isCLOSINGorCLOSEDbufferedAmountattribute by the length of thedataargument in bytes.
callbackfunction with an error.Fixes #1515