From 297f56df79f6bf4757465fb6b59884faf5b75337 Mon Sep 17 00:00:00 2001 From: Luigi Pinca Date: Thu, 21 Mar 2019 07:35:33 +0100 Subject: [PATCH] [minor] Remove unneeded `if` statement The `'error'` event can be emitted after the `'close'` event only if `socket.write()` is called on a closed socket. If this happens, it's a bug. --- lib/websocket.js | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/websocket.js b/lib/websocket.js index 0dd5fb27b..32f092f81 100644 --- a/lib/websocket.js +++ b/lib/websocket.js @@ -893,8 +893,6 @@ function socketOnError() { this.removeListener('error', socketOnError); this.on('error', NOOP); - if (websocket) { - websocket.readyState = WebSocket.CLOSING; - this.destroy(); - } + websocket.readyState = WebSocket.CLOSING; + this.destroy(); }