Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show GitHub and npm urls #422

Merged
merged 6 commits into from Dec 19, 2018
Merged

Conversation

nidkil
Copy link
Contributor

@nidkil nidkil commented Dec 16, 2018

This is related to issue #417.

Added message that is displayed on completion with URLs to go to the GitHub repository and the NPM package. In a lot of terminals this URLs are displayed as clickable making it easy to jump to them and do a quick check.

@nidkil
Copy link
Contributor Author

nidkil commented Dec 16, 2018

I forgot to merge the upstream before making the changes. Fixed the code after merging upstream.

@nidkil
Copy link
Contributor Author

nidkil commented Dec 17, 2018

Fixed failing test.

Copy link
Collaborator

@webpro webpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR, @nidkil! I've added a few comments, please have a look.

lib/config.js Outdated Show resolved Hide resolved
lib/tasks.js Outdated Show resolved Hide resolved
lib/tasks.js Outdated Show resolved Hide resolved
lib/tasks.js Outdated Show resolved Hide resolved
@webpro webpro merged commit cef3566 into release-it:master Dec 19, 2018
@webpro
Copy link
Collaborator

webpro commented Dec 19, 2018

Thanks @nidkil! The new feature is released in v9.2.0.

@nidkil
Copy link
Contributor Author

nidkil commented Dec 19, 2018

Cool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants