From d7ae9adfb2e9435cb740512fd48e2f9f7f5b8daa Mon Sep 17 00:00:00 2001 From: Tim Sebastian Date: Sat, 18 Mar 2017 12:20:08 +1100 Subject: [PATCH 1/2] do not incorporate chunks without modules --- lib/optimize/FlagIncludedChunksPlugin.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/optimize/FlagIncludedChunksPlugin.js b/lib/optimize/FlagIncludedChunksPlugin.js index f500b0e510e..4fa9b1f9d6d 100644 --- a/lib/optimize/FlagIncludedChunksPlugin.js +++ b/lib/optimize/FlagIncludedChunksPlugin.js @@ -19,6 +19,8 @@ class FlagIncludedChunksPlugin { // as we loop twice the current A will be B and B then A if(chunkA.modules.length < chunkB.modules.length) return; + if(chunkB.modules.length === 0) return; + // is chunkB in chunkA? for(let i = 0; i < chunkB.modules.length; i++) { if(chunkA.modules.indexOf(chunkB.modules[i]) < 0) return; From d67e12597637d6486a56833603a3379fae5b9a99 Mon Sep 17 00:00:00 2001 From: Tim Sebastian Date: Sat, 18 Mar 2017 12:28:21 +1100 Subject: [PATCH 2/2] fix up tests --- test/statsCases/commons-chunk-min-size-0/expected.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/statsCases/commons-chunk-min-size-0/expected.txt b/test/statsCases/commons-chunk-min-size-0/expected.txt index 6673a030ede..82bc8923530 100644 --- a/test/statsCases/commons-chunk-min-size-0/expected.txt +++ b/test/statsCases/commons-chunk-min-size-0/expected.txt @@ -1,8 +1,8 @@ -Hash: 9beb53e88067f8ed0026 +Hash: dc6038bec87a57d1a45e Time: Xms Asset Size Chunks Chunk Names entry-1.js 25 bytes 0 [emitted] entry-1 -vendor-1.js 6.72 kB 1, 0 [emitted] vendor-1 +vendor-1.js 6.7 kB 1 [emitted] vendor-1 chunk {0} entry-1.js (entry-1) 0 bytes {1} [initial] [rendered] chunk {1} vendor-1.js (vendor-1) 329 bytes [entry] [rendered] [0] (webpack)/test/statsCases/commons-chunk-min-size-0/modules/a.js 22 bytes {1} [built]