From 7ebe12dde12a62301fb8979917592fdd5a51012a Mon Sep 17 00:00:00 2001
From: Tobias Koppers <tobias.koppers@googlemail.com>
Date: Sun, 27 May 2018 21:47:23 +0200
Subject: [PATCH] throw error when unexpected state has been found

---
 lib/RuntimeTemplate.js | 24 +++++++++++++++++++++---
 1 file changed, 21 insertions(+), 3 deletions(-)

diff --git a/lib/RuntimeTemplate.js b/lib/RuntimeTemplate.js
index 3cb912a20ee..862734cdd62 100644
--- a/lib/RuntimeTemplate.js
+++ b/lib/RuntimeTemplate.js
@@ -65,10 +65,16 @@ module.exports = class RuntimeTemplate {
 	}
 
 	moduleId({ module, request }) {
-		if (!module)
+		if (!module) {
 			return this.missingModule({
 				request
 			});
+		}
+		if (module.id === null) {
+			throw new Error(
+				`RuntimeTemplate.moduleId(): Module ${module.identifier()} has no id. This should not happen.`
+			);
+		}
 		return `${this.comment({ request })}${JSON.stringify(module.id)}`;
 	}
 
@@ -105,10 +111,16 @@ module.exports = class RuntimeTemplate {
 	}
 
 	moduleNamespacePromise({ block, module, request, message, strict, weak }) {
-		if (!module)
+		if (!module) {
 			return this.missingModulePromise({
 				request
 			});
+		}
+		if (module.id === null) {
+			throw new Error(
+				`RuntimeTemplate.moduleNamespacePromise(): Module ${module.identifier()} has no id. This should not happen.`
+			);
+		}
 		const promise = this.blockPromise({
 			block,
 			message
@@ -151,10 +163,16 @@ module.exports = class RuntimeTemplate {
 	}
 
 	importStatement({ update, module, request, importVar, originModule }) {
-		if (!module)
+		if (!module) {
 			return this.missingModuleStatement({
 				request
 			});
+		}
+		if (module.id === null) {
+			throw new Error(
+				`RuntimeTemplate.importStatement(): Module ${module.identifier()} has no id. This should not happen.`
+			);
+		}
 		const comment = this.comment({
 			request
 		});