From 3a41ca4ee223a93803cb9e0cfc27e2306699f154 Mon Sep 17 00:00:00 2001 From: zacanger Date: Thu, 1 Mar 2018 17:09:01 -0700 Subject: [PATCH 1/2] Fix #6644 --- lib/optimize/SplitChunksPlugin.js | 2 +- test/configCases/split-chunks/no-options/a.js | 1 + test/configCases/split-chunks/no-options/index.js | 6 ++++++ .../split-chunks/no-options/test.config.js | 5 +++++ .../split-chunks/no-options/webpack.config.js | 13 +++++++++++++ 5 files changed, 26 insertions(+), 1 deletion(-) create mode 100644 test/configCases/split-chunks/no-options/a.js create mode 100644 test/configCases/split-chunks/no-options/index.js create mode 100644 test/configCases/split-chunks/no-options/test.config.js create mode 100644 test/configCases/split-chunks/no-options/webpack.config.js diff --git a/lib/optimize/SplitChunksPlugin.js b/lib/optimize/SplitChunksPlugin.js index 9cbd3408780..f971534ed6f 100644 --- a/lib/optimize/SplitChunksPlugin.js +++ b/lib/optimize/SplitChunksPlugin.js @@ -83,7 +83,7 @@ module.exports = class SplitChunksPlugin { this.options = SplitChunksPlugin.normalizeOptions(options); } - static normalizeOptions(options) { + static normalizeOptions(options = {}) { return { chunks: options.chunks || "all", minSize: options.minSize || 0, diff --git a/test/configCases/split-chunks/no-options/a.js b/test/configCases/split-chunks/no-options/a.js new file mode 100644 index 00000000000..6cd1d0075d4 --- /dev/null +++ b/test/configCases/split-chunks/no-options/a.js @@ -0,0 +1 @@ +module.exports = "a"; diff --git a/test/configCases/split-chunks/no-options/index.js b/test/configCases/split-chunks/no-options/index.js new file mode 100644 index 00000000000..b5158af8104 --- /dev/null +++ b/test/configCases/split-chunks/no-options/index.js @@ -0,0 +1,6 @@ +require("should"); + +it("should run", function() { + var a = require("./a"); + a.should.be.eql("a"); +}); diff --git a/test/configCases/split-chunks/no-options/test.config.js b/test/configCases/split-chunks/no-options/test.config.js new file mode 100644 index 00000000000..6f3aaf93f4f --- /dev/null +++ b/test/configCases/split-chunks/no-options/test.config.js @@ -0,0 +1,5 @@ +module.exports = { + findBundle: function(i, options) { + return ["vendor.js", "main.js"]; + } +}; diff --git a/test/configCases/split-chunks/no-options/webpack.config.js b/test/configCases/split-chunks/no-options/webpack.config.js new file mode 100644 index 00000000000..16fb5373352 --- /dev/null +++ b/test/configCases/split-chunks/no-options/webpack.config.js @@ -0,0 +1,13 @@ +const SplitChunksPlugin = require("../../../../lib/optimize/SplitChunksPlugin"); + +module.exports = { + entry: { + vendor: ["./a"], + main: "./index" + }, + target: "web", + output: { + filename: "[name].js" + }, + plugins: [new SplitChunksPlugin()] +}; From b0e14df9ce2af4efafe98be44c2235ffa1ba9d7e Mon Sep 17 00:00:00 2001 From: zacanger Date: Fri, 2 Mar 2018 09:50:13 -0700 Subject: [PATCH 2/2] Set optimization.splitChunks to false in test webpack config. --- test/configCases/split-chunks/no-options/webpack.config.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/test/configCases/split-chunks/no-options/webpack.config.js b/test/configCases/split-chunks/no-options/webpack.config.js index 16fb5373352..eb349acba83 100644 --- a/test/configCases/split-chunks/no-options/webpack.config.js +++ b/test/configCases/split-chunks/no-options/webpack.config.js @@ -9,5 +9,8 @@ module.exports = { output: { filename: "[name].js" }, + optimization: { + splitChunks: false + }, plugins: [new SplitChunksPlugin()] };