diff --git a/lib/optimize/SplitChunksPlugin.js b/lib/optimize/SplitChunksPlugin.js index 96e3ca75099..c65eaa4d101 100644 --- a/lib/optimize/SplitChunksPlugin.js +++ b/lib/optimize/SplitChunksPlugin.js @@ -83,7 +83,7 @@ module.exports = class SplitChunksPlugin { this.options = SplitChunksPlugin.normalizeOptions(options); } - static normalizeOptions(options) { + static normalizeOptions(options = {}) { return { chunks: options.chunks || "all", minSize: options.minSize || 0, diff --git a/test/configCases/split-chunks/no-options/a.js b/test/configCases/split-chunks/no-options/a.js new file mode 100644 index 00000000000..6cd1d0075d4 --- /dev/null +++ b/test/configCases/split-chunks/no-options/a.js @@ -0,0 +1 @@ +module.exports = "a"; diff --git a/test/configCases/split-chunks/no-options/index.js b/test/configCases/split-chunks/no-options/index.js new file mode 100644 index 00000000000..b5158af8104 --- /dev/null +++ b/test/configCases/split-chunks/no-options/index.js @@ -0,0 +1,6 @@ +require("should"); + +it("should run", function() { + var a = require("./a"); + a.should.be.eql("a"); +}); diff --git a/test/configCases/split-chunks/no-options/test.config.js b/test/configCases/split-chunks/no-options/test.config.js new file mode 100644 index 00000000000..6f3aaf93f4f --- /dev/null +++ b/test/configCases/split-chunks/no-options/test.config.js @@ -0,0 +1,5 @@ +module.exports = { + findBundle: function(i, options) { + return ["vendor.js", "main.js"]; + } +}; diff --git a/test/configCases/split-chunks/no-options/webpack.config.js b/test/configCases/split-chunks/no-options/webpack.config.js new file mode 100644 index 00000000000..eb349acba83 --- /dev/null +++ b/test/configCases/split-chunks/no-options/webpack.config.js @@ -0,0 +1,16 @@ +const SplitChunksPlugin = require("../../../../lib/optimize/SplitChunksPlugin"); + +module.exports = { + entry: { + vendor: ["./a"], + main: "./index" + }, + target: "web", + output: { + filename: "[name].js" + }, + optimization: { + splitChunks: false + }, + plugins: [new SplitChunksPlugin()] +};