fix(regression): host and port can be undefined or null #1779
+458
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
force-pushed
the
fix(regression)-host-and-port-can-be-undefined-or-null
branch
from
9f19116
to
229ec96
Compare
Codecov Report
@@ Coverage Diff @@
## master #1779 +/- ##
=======================================
Coverage 87.62% 87.62%
=======================================
Files 9 9
Lines 590 590
Branches 176 176
=======================================
Hits 517 517
Misses 61 61
Partials 12 12Continue to review full report at Codecov.
|
hiroppy
approved these changes
Apr 9, 2019
alexander-akait
force-pushed
the
fix(regression)-host-and-port-can-be-undefined-or-null
branch
from
229ec96
to
01fc990
Compare
alexander-akait
deleted the
fix(regression)-host-and-port-can-be-undefined-or-null
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Yes, many
Motivation / Use-Case
Previously we allow
hostandportto benull/undefinedBreaking Changes
No
Additional Info
No