Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check origin header for websocket connection #1603

Merged
merged 3 commits into from Dec 21, 2018

Conversation

sokra
Copy link
Member

@sokra sokra commented Dec 21, 2018

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

no

Motivation / Use-Case

security fix

Breaking Changes

websocket is now checked for origin

Additional Info

@alexander-akait
Copy link
Member

Need fix lint problems

@codecov
Copy link

codecov bot commented Dec 21, 2018

Codecov Report

Merging #1603 into master will increase coverage by 0.03%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1603      +/-   ##
=========================================
+ Coverage   74.06%   74.1%   +0.03%     
=========================================
  Files          10      10              
  Lines         671     672       +1     
=========================================
+ Hits          497     498       +1     
  Misses        174     174
Impacted Files Coverage Δ
lib/Server.js 81.47% <60%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68dd49a...7b9c846. Read the comment docs.

@alexander-akait alexander-akait merged commit b3217ca into master Dec 21, 2018
@alexander-akait alexander-akait deleted the bugfix/origin-header branch December 21, 2018 17:00
ticky added a commit to buildkite/frontend that referenced this pull request Jan 30, 2019
This was referenced Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants