fix(package): update spdy v3.4.1...4.0.0 (assertion error) (#1491)

[odinho]

• This is a bugfix
• This is a feature
• This is a code refactor
• This is a test update
• This is a docs update
• This is a metadata update

For Bugs and Features; did you add new tests?

No. Upstream issue.

Motivation / Use-Case

• Fixes issue AssertionError in spdy-transport consistently causing failures while running in Chrome 69 #1491 (AssertionError in spdy-transport consistently causing failures while running in Chrome 69)
• Upstream bug: AssertionError [ERR_ASSERTION]: false == true spdy-http2/spdy-transport#47 (comment)

Breaking Changes

No breaking change. Changelog for upstream:

• spdy-http2/node-spdy@v3.4.7...v4.0.0
• (the ALPN changes are just their own tests)
• most other changes are sub-dependency updates

Additional Info

No.

[jsf-clabot]

All committers have signed the CLA.

[alexander-akait]

Good job! Looks tests failed 😞

[odinho]

Interesting. Seems to both error and fail/crash (/Users/travis/.travis/job_stages: line 104: 3028 Segmentation fault: 11 npm run $SCRIPT) on Mac OS X. That is worrying.

Seems like same errors are on master branch though. Only there Linux dies in the same way before Mac OS X gets to run.

So I'll just re-run it later when whatever problems Travis or master are having have been resolved.

[odinho]

If anything #1543 looks suspicious. It was added to master with its Travis check failing. Both commits since then have failed. The commit before was cancelled, so it actually never got to run a Travis build (but it was also only metadata update).

[alexander-akait]

Can we fix it here?

[odinho]

Maybe remove all caches? https://docs.travis-ci.com/user/common-build-problems/#segmentation-faults-from-the-language-interpreter-ruby-python-php-nodejs-etc

I have tried some runs with what looked like the culprit removed (#1564) , but it still crashes (only stable though). So if you could kick Travis a bit, remove its caches, that might fix it?

Howto clear cache from webui: https://docs.travis-ci.com/user/caching#clearing-caches

[alexander-akait]

No cache setup for this package to avoid same problem

[codecov]

Codecov Report

Merging #1563 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1563   +/-   ##
=======================================
  Coverage   74.02%   74.02%           
=======================================
  Files          10       10           
  Lines         670      670           
=======================================
  Hits          496      496           
  Misses        174      174

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fe82de...8c9944a. Read the comment docs.

[odinho]

I've opened a bug with Node.js, hoping they can figure it out. nodejs/node#24835

An alternative (that I've been thinking of), is to change your test to test Node 10 instead of Node/stable (which now is Node 11.3.0, but this does not seem stable :P).

[alexander-akait]

@odinho very thanks for helping, let's disable test and put comment with link on issue 👍

[odinho]

@odinho very thanks for helping, let's disable test and put comment with link on issue

I've added #1588

[alexander-akait]

@odinho do we have way testing this?

[odinho]

@odinho do we have way testing this?

It is an upstream bug, which is tricky to test in a good way downstream. That bug also only surfaced because Chromium fixed something on their side if I understand correctly. So I'm unsure how that would play out.

Something that could have caught it would be a stress-test where a browser + the dev server is interacting for a long time (say 10 mins) with lots of different changes.

Normally, updated version of dependencies won't really get their own tests. Even though having some test that would be able to find such issues would of course be helpful. (Though it'd be prone to noise and flaking, and it would be very little help in actually diagnosing the issues)

[alexander-akait]

@odinho okay, let's merge this