From e603e0d050bbab61c49c92abd01af84b9fbf02fd Mon Sep 17 00:00:00 2001 From: Ryan Clark Date: Sat, 17 Feb 2018 10:26:27 +0000 Subject: [PATCH] Allow no publicPath or entry point (#1310) * fix(addDevServerEntrypoints): allow no entry point to be given * test(entry): ensure src is added as default if no entry specified --- lib/util/addDevServerEntrypoints.js | 2 +- test/Entry.test.js | 18 ++++++++++++++++++ 2 files changed, 19 insertions(+), 1 deletion(-) create mode 100644 test/Entry.test.js diff --git a/lib/util/addDevServerEntrypoints.js b/lib/util/addDevServerEntrypoints.js index d3d95b3a32..8007049008 100644 --- a/lib/util/addDevServerEntrypoints.js +++ b/lib/util/addDevServerEntrypoints.js @@ -27,7 +27,7 @@ module.exports = function addDevServerEntrypoints(webpackOptions, devServerOptio } else if (typeof wpOpt.entry === 'function') { wpOpt.entry = wpOpt.entry(devClient); } else { - wpOpt.entry = devClient.concat(wpOpt.entry); + wpOpt.entry = devClient.concat(wpOpt.entry || './src'); } }); } diff --git a/test/Entry.test.js b/test/Entry.test.js new file mode 100644 index 0000000000..1ccb2ae6e9 --- /dev/null +++ b/test/Entry.test.js @@ -0,0 +1,18 @@ +'use strict'; + +const assert = require('assert'); +const addDevServerEntrypoints = require('../lib/util/addDevServerEntrypoints'); + +describe('Entry', () => { + it('default to src if no entry point is given', (done) => { + const webpackOptions = {}; + const devServerOptions = {}; + + addDevServerEntrypoints(webpackOptions, devServerOptions); + + assert(webpackOptions.entry.length, 2); + assert(webpackOptions.entry[1], './src'); + + done(); + }); +});