Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support HEAD method by default #398

Merged
merged 3 commits into from May 14, 2019

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Support HEAD method by default

Breaking Changes

No

Additional Info

No

@alexander-akait
Copy link
Member Author

/cc @hiroppy need review

@alexander-akait alexander-akait mentioned this pull request May 14, 2019
6 tasks
@codecov
Copy link

codecov bot commented May 14, 2019

Codecov Report

Merging #398 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #398   +/-   ##
=======================================
  Coverage   97.03%   97.03%           
=======================================
  Files           7        7           
  Lines         304      304           
  Branches      103      103           
=======================================
  Hits          295      295           
  Misses          9        9
Impacted Files Coverage Δ
lib/middleware.js 94.91% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f227570...2900536. Read the comment docs.

@hiroppy
Copy link
Member

hiroppy commented May 14, 2019

🤔

https://dev.azure.com/webpack/webpack-dev-middleware/_build/results?buildId=2689

> webpack-dev-middleware@3.6.2 security /home/vsts/work/1/s
> npm audit

npm ERR! code ENOAUDIT
npm ERR! audit Your configured registry (https://registry.npmjs.org/) does not support audit requests, or the audit endpoint is temporarily unavailable.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/vsts/.npm/_logs/2019-05-14T19_07_11_131Z-debug.log
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! webpack-dev-middleware@3.6.2 security: `npm audit`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the webpack-dev-middleware@3.6.2 security script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/vsts/.npm/_logs/2019-05-14T19_07_14_437Z-debug.log
##[error]Bash exited with code '1'.
##[section]Finishing: Run NPM audit

@alexander-akait
Copy link
Member Author

npm register is very bad

@hiroppy
Copy link
Member

hiroppy commented May 14, 2019

Thanks!

@hiroppy hiroppy merged commit ec3d5eb into master May 14, 2019
@hiroppy hiroppy deleted the feat-support-head-method-by-default branch May 14, 2019 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants