Remove querystring from filenames when writing to disk

[GregWeil]

What kind of change does this PR introduce?

This is a bug fix to bring file writing behavior closer to that of webpack and the WriteFilePlugin.

Did you add tests for your changes?

Yes

Summary

Webpack and the WriteFilePlugin cut off filenames at the first ?, so you can use filenames like '[name].js?[contenthash]' without writing hashes to your filesystem. This updates the dev middleware to do the same when writeToDisk is enabled.

Does this PR introduce a breaking change?

If you were using writeToDisk with a ? in output.filename then you won't end up with a ? in filenames on disk any more. If you pass a filter function to writeToDisk then that function will also stop getting the querystring.

Other information

Here's where querystrings get cut off in webpack and the writefileplugin:
https://github.com/webpack/webpack/blob/v4.28.4/lib/Compiler.js#L321
https://github.com/gajus/write-file-webpack-plugin/blob/v4.4.0/src/WriteFileWebpackPlugin.js#L174

[jsf-clabot]

All committers have signed the CLA.

[codecov]

Codecov Report

Merging #361 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #361      +/-   ##
==========================================
+ Coverage   96.82%   96.83%   +0.01%     
==========================================
  Files           7        7              
  Lines         252      253       +1     
==========================================
+ Hits          244      245       +1     
  Misses          8        8

Impacted Files	Coverage Δ
lib/fs.js	95.23% <100%> (+0.11%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e8ac82...f794c8b. Read the comment docs.

[codecov]

Codecov Report

Merging #361 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #361      +/-   ##
==========================================
+ Coverage   96.82%   96.83%   +0.01%     
==========================================
  Files           7        7              
  Lines         252      253       +1     
==========================================
+ Hits          244      245       +1     
  Misses          8        8

Impacted Files	Coverage Δ
lib/fs.js	95.23% <100%> (+0.11%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e8ac82...f794c8b. Read the comment docs.

[alexander-akait]

Good job, we use same logic in webpack https://github.com/webpack/webpack/blob/master/lib/Compiler.js#L319, maybe we can increase perf using split in webpack

[alexander-akait]

Released in https://github.com/webpack/webpack-dev-middleware/releases/tag/v3.5.1