From c487032f5c371eb9f21f92beb0beb432f35ad7bb Mon Sep 17 00:00:00 2001 From: Dhruvdutt Jadhav Date: Mon, 9 Apr 2018 19:24:44 +0530 Subject: [PATCH] cli(init): mode support to config (#364) * cli(init): mode support to config --- lib/generators/init-generator.js | 8 +++++--- .../mode/__snapshots__/mode.test.js.snap | 14 ++++++++++++++ lib/init/transformations/mode/mode.test.js | 2 ++ 3 files changed, 21 insertions(+), 3 deletions(-) diff --git a/lib/generators/init-generator.js b/lib/generators/init-generator.js index 09a29dc2e78..cdd871d0a44 100644 --- a/lib/generators/init-generator.js +++ b/lib/generators/init-generator.js @@ -115,9 +115,11 @@ module.exports = class InitGenerator extends Generator { Confirm("prodConfirm", "Are you going to use this in production?") ]); }) - .then( - prodConfirmAnswer => (this.isProd = prodConfirmAnswer["prodConfirm"]) - ) + .then(prodConfirmAnswer => { + this.isProd = prodConfirmAnswer["prodConfirm"]; + this.configuration.config.webpackOptions.mode = + this.isProd ? `"${"production"}"` : `"${"development"}"`; + }) .then(() => { return this.prompt([ Confirm("babelConfirm", "Will you be using ES2015?") diff --git a/lib/init/transformations/mode/__snapshots__/mode.test.js.snap b/lib/init/transformations/mode/__snapshots__/mode.test.js.snap index ddb18a7f1cf..9b457a427bc 100644 --- a/lib/init/transformations/mode/__snapshots__/mode.test.js.snap +++ b/lib/init/transformations/mode/__snapshots__/mode.test.js.snap @@ -8,6 +8,13 @@ exports[`mode transforms correctly using "mode-1" data 1`] = ` `; exports[`mode transforms correctly using "mode-1" data 2`] = ` +"module.exports = { + mode: 'development' +}; +" +`; + +exports[`mode transforms correctly using "mode-1" data 3`] = ` "module.exports = { mode: modeVariable }; @@ -27,3 +34,10 @@ exports[`mode transforms correctly using "mode-2" data 2`] = ` } " `; + +exports[`mode transforms correctly using "mode-2" data 3`] = ` +"module.exports = { + mode: 'development' +} +" +`; diff --git a/lib/init/transformations/mode/mode.test.js b/lib/init/transformations/mode/mode.test.js index b5bc662fb73..66dc6c2a570 100644 --- a/lib/init/transformations/mode/mode.test.js +++ b/lib/init/transformations/mode/mode.test.js @@ -3,7 +3,9 @@ const defineTest = require("../../../utils/defineTest"); defineTest(__dirname, "mode", "mode-1", "'production'", "init"); +defineTest(__dirname, "mode", "mode-1", "'development'", "init"); defineTest(__dirname, "mode", "mode-1", "modeVariable", "init"); defineTest(__dirname, "mode", "mode-2", "none", "add"); defineTest(__dirname, "mode", "mode-2", "'production'", "add"); +defineTest(__dirname, "mode", "mode-2", "'development'", "add");