From d4643ae5d0749a53dff6adaeb2f50fb6d48bceaf Mon Sep 17 00:00:00 2001 From: "devid.farinelli@gmail.com" Date: Fri, 26 Apr 2019 19:35:59 +0200 Subject: [PATCH 1/3] feat(opencollective prompt): add option to disable it + doc --- README.md | 16 ++++++++++++---- bin/opencollective.js | 7 ++++++- 2 files changed, 18 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index 7238f3fede1..af6864f0f8d 100644 --- a/README.md +++ b/README.md @@ -23,12 +23,14 @@ [![GitHub contributors](https://img.shields.io/github/contributors/webpack/webpack-cli.svg)](https://github.com/webpack/webpack-cli/graphs/contributors) - [About](#about) - - [How to install](#how-to-install) -- [Getting Started](#getting-started) + - [How to install](#how-to-install) +- [Packages](#packages) + - [Commands](#commands) + - [Utilities](#utilities) +- [Getting started](#getting-started) - [webpack CLI Scaffolds](#webpack-cli-scaffolds) -- [Commands](#commands) -- [webpack.config.js](https://webpack.js.org/concepts/configuration/) - [Contributing and Internal Documentation](#contributing-and-internal-documentation) +- [Open Collective](#open-collective) ## About @@ -89,3 +91,9 @@ The webpack family welcomes any contributor, small or big. We are happy to elabo [deps]: https://img.shields.io/david/webpack/webpack.svg [deps-url]: https://david-dm.org/webpack/webpack-cli + +## Open Collective + +If you like **webpack** Please consider donating to our [Open Collective](https://opencollective.com/webpack) to help us maintain it. + +We show this message in the terminal once in a while, if you want you can disable it by setting the environment variable `DISABLE_OPENCOLLECTIVE=true` or `CI=true`. \ No newline at end of file diff --git a/bin/opencollective.js b/bin/opencollective.js index a6266a25b4e..3d8a2966d23 100644 --- a/bin/opencollective.js +++ b/bin/opencollective.js @@ -30,4 +30,9 @@ function printBadge() { console.log("\n"); } -printBadge(); +function isTrue(value) { + return !!value && value !== "0" && value !== "false"; +} +var envDisable = isTrue(process.env.DISABLE_OPENCOLLECTIVE) || isTrue(process.env.CI); + +if (!envDisable) printBadge(); From 246db427642750a6a8b59b37d6797c74b6ff9846 Mon Sep 17 00:00:00 2001 From: Devid Farinelli Date: Sun, 28 Apr 2019 01:35:12 +0200 Subject: [PATCH 2/3] fix(opencollective prompt): fix grammar --- README.md | 4 ++-- bin/opencollective.js | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index af6864f0f8d..4ea446c1739 100644 --- a/README.md +++ b/README.md @@ -94,6 +94,6 @@ The webpack family welcomes any contributor, small or big. We are happy to elabo ## Open Collective -If you like **webpack** Please consider donating to our [Open Collective](https://opencollective.com/webpack) to help us maintain it. +If you like **webpack** Please consider donating to our [Open Collective](https://opencollective.com/webpack) to help us to maintain it. -We show this message in the terminal once in a while, if you want you can disable it by setting the environment variable `DISABLE_OPENCOLLECTIVE=true` or `CI=true`. \ No newline at end of file +We show this message in the terminal once a week, if you want you can disable it by setting the environment variable `DISABLE_OPENCOLLECTIVE=true` or `CI=true`. \ No newline at end of file diff --git a/bin/opencollective.js b/bin/opencollective.js index 3d8a2966d23..c09e43b1394 100644 --- a/bin/opencollective.js +++ b/bin/opencollective.js @@ -24,7 +24,7 @@ function printBadge() { console.log("\n"); print(`${chalk.bold("Thanks for using")} ${chalk.bold.blue("Webpack!")}`); print(`Please consider donating to our ${chalk.bold.blue("Open Collective")}`); - print("to help us maintain this package."); + print("to help us to maintain this package."); console.log("\n\n"); print(`${emoji("👉")} ${chalk.bold.yellow(" Donate:")} ${chalk.reset.underline.yellow("https://opencollective.com/webpack/donate")}`); console.log("\n"); @@ -33,6 +33,6 @@ function printBadge() { function isTrue(value) { return !!value && value !== "0" && value !== "false"; } -var envDisable = isTrue(process.env.DISABLE_OPENCOLLECTIVE) || isTrue(process.env.CI); +const envDisable = isTrue(process.env.DISABLE_OPENCOLLECTIVE) || isTrue(process.env.CI); if (!envDisable) printBadge(); From e17a26daf01ae0463669e7dc735eb8d8b40ac860 Mon Sep 17 00:00:00 2001 From: "devid.farinelli@gmail.com" Date: Thu, 2 May 2019 18:11:00 +0200 Subject: [PATCH 3/3] misc(opencollective-prompt): improve grammar --- README.md | 2 +- bin/opencollective.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 4ea446c1739..f49ac356f6c 100644 --- a/README.md +++ b/README.md @@ -94,6 +94,6 @@ The webpack family welcomes any contributor, small or big. We are happy to elabo ## Open Collective -If you like **webpack** Please consider donating to our [Open Collective](https://opencollective.com/webpack) to help us to maintain it. +If you like **webpack**, please consider donating to our [Open Collective](https://opencollective.com/webpack) to help us maintain it. We show this message in the terminal once a week, if you want you can disable it by setting the environment variable `DISABLE_OPENCOLLECTIVE=true` or `CI=true`. \ No newline at end of file diff --git a/bin/opencollective.js b/bin/opencollective.js index c09e43b1394..c8e81b3da6c 100644 --- a/bin/opencollective.js +++ b/bin/opencollective.js @@ -24,7 +24,7 @@ function printBadge() { console.log("\n"); print(`${chalk.bold("Thanks for using")} ${chalk.bold.blue("Webpack!")}`); print(`Please consider donating to our ${chalk.bold.blue("Open Collective")}`); - print("to help us to maintain this package."); + print("to help us maintain this package."); console.log("\n\n"); print(`${emoji("👉")} ${chalk.bold.yellow(" Donate:")} ${chalk.reset.underline.yellow("https://opencollective.com/webpack/donate")}`); console.log("\n");